New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get cmd line #310
Get cmd line #310
Conversation
src/windows/process.rs
Outdated
res | ||
fn get_cmd_line(handle: HANDLE) -> Vec<String> { | ||
if *WINDOWS_8_1_OR_NEWER | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very weird formatting. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why, but on this project cargo fmt doesn't work on my computer <_<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dark magic. :D
Can you also provide a benchmark difference between before and after too please? Otherwise, apart from the |
You forgot to add a condition on |
Just the benchmark comparison remaining now and I think we're good to go. |
Benchmark results. Before:
After:
|
So not much changes. This is pretty good news. |
Thanks! |
This is new window command-line getting approach, same as ProcessHacker uses. The approach doesn't require PROCESS_VM_READ access right and works with 32 and 64 bit processes. But unfortunately, it doesn't work in windows 8 and older.