From 9d74c9fc3bbeb0ede90134f77d0f60d580b4bcc5 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 26 Aug 2025 17:54:38 +0000 Subject: [PATCH 1/2] build(deps-dev): bump vite from 6.3.5 to 7.1.3 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.5 to 7.1.3. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.3/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- package-lock.json | 116 ++++++++++++++++++++++++++++++++++++++-------- package.json | 2 +- 2 files changed, 98 insertions(+), 20 deletions(-) diff --git a/package-lock.json b/package-lock.json index c7853a609..3cc8f6c3d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -65,7 +65,7 @@ "ts-morph": "^26.0.0", "tsx": "^4.20.4", "typescript-eslint": "^8.40.0", - "vite": "^6.2.7", + "vite": "^7.1.3", "vite-plugin-checker": "^0.9.1", "vite-plugin-circular-dependency": "^0.5.0", "vite-plugin-dts": "^4.5.3", @@ -2330,6 +2330,81 @@ "react": "^16.8.4 || ^17.0.0 || ^18.0.0" } }, + "node_modules/@ladle/react/node_modules/vite": { + "version": "6.3.5", + "resolved": "https://registry.npmjs.org/vite/-/vite-6.3.5.tgz", + "integrity": "sha512-cZn6NDFE7wdTpINgs++ZJ4N49W2vRp8LCKrn3Ob1kYNtOo21vfDoaV5GzBfLU4MovSAB8uNRm4jgzVQZ+mBzPQ==", + "dev": true, + "license": "MIT", + "dependencies": { + "esbuild": "^0.25.0", + "fdir": "^6.4.4", + "picomatch": "^4.0.2", + "postcss": "^8.5.3", + "rollup": "^4.34.9", + "tinyglobby": "^0.2.13" + }, + "bin": { + "vite": "bin/vite.js" + }, + "engines": { + "node": "^18.0.0 || ^20.0.0 || >=22.0.0" + }, + "funding": { + "url": "https://github.com/vitejs/vite?sponsor=1" + }, + "optionalDependencies": { + "fsevents": "~2.3.3" + }, + "peerDependencies": { + "@types/node": "^18.0.0 || ^20.0.0 || >=22.0.0", + "jiti": ">=1.21.0", + "less": "*", + "lightningcss": "^1.21.0", + "sass": "*", + "sass-embedded": "*", + "stylus": "*", + "sugarss": "*", + "terser": "^5.16.0", + "tsx": "^4.8.1", + "yaml": "^2.4.2" + }, + "peerDependenciesMeta": { + "@types/node": { + "optional": true + }, + "jiti": { + "optional": true + }, + "less": { + "optional": true + }, + "lightningcss": { + "optional": true + }, + "sass": { + "optional": true + }, + "sass-embedded": { + "optional": true + }, + "stylus": { + "optional": true + }, + "sugarss": { + "optional": true + }, + "terser": { + "optional": true + }, + "tsx": { + "optional": true + }, + "yaml": { + "optional": true + } + } + }, "node_modules/@mdx-js/mdx": { "version": "3.1.0", "resolved": "https://registry.npmjs.org/@mdx-js/mdx/-/mdx-3.1.0.tgz", @@ -10135,11 +10210,14 @@ } }, "node_modules/fdir": { - "version": "6.4.6", - "resolved": "https://registry.npmjs.org/fdir/-/fdir-6.4.6.tgz", - "integrity": "sha512-hiFoqpyZcfNm1yc4u8oWCf9A2c4D3QjCrks3zmoVKVxpQRzmPNar1hUJcBG2RQHvEVGDN+Jm81ZheVLAQMK6+w==", + "version": "6.5.0", + "resolved": "https://registry.npmjs.org/fdir/-/fdir-6.5.0.tgz", + "integrity": "sha512-tIbYtZbucOs0BRGqPJkshJUYdL+SDH7dVM8gjy+ERp3WAUjLEFJE+02kanyHtwjWOnwrKYBiwAmM0p4kLJAnXg==", "dev": true, "license": "MIT", + "engines": { + "node": ">=12.0.0" + }, "peerDependencies": { "picomatch": "^3 || ^4" }, @@ -19303,24 +19381,24 @@ } }, "node_modules/vite": { - "version": "6.3.5", - "resolved": "https://registry.npmjs.org/vite/-/vite-6.3.5.tgz", - "integrity": "sha512-cZn6NDFE7wdTpINgs++ZJ4N49W2vRp8LCKrn3Ob1kYNtOo21vfDoaV5GzBfLU4MovSAB8uNRm4jgzVQZ+mBzPQ==", + "version": "7.1.3", + "resolved": "https://registry.npmjs.org/vite/-/vite-7.1.3.tgz", + "integrity": "sha512-OOUi5zjkDxYrKhTV3V7iKsoS37VUM7v40+HuwEmcrsf11Cdx9y3DIr2Px6liIcZFwt3XSRpQvFpL3WVy7ApkGw==", "dev": true, "license": "MIT", "dependencies": { "esbuild": "^0.25.0", - "fdir": "^6.4.4", - "picomatch": "^4.0.2", - "postcss": "^8.5.3", - "rollup": "^4.34.9", - "tinyglobby": "^0.2.13" + "fdir": "^6.5.0", + "picomatch": "^4.0.3", + "postcss": "^8.5.6", + "rollup": "^4.43.0", + "tinyglobby": "^0.2.14" }, "bin": { "vite": "bin/vite.js" }, "engines": { - "node": "^18.0.0 || ^20.0.0 || >=22.0.0" + "node": "^20.19.0 || >=22.12.0" }, "funding": { "url": "https://github.com/vitejs/vite?sponsor=1" @@ -19329,14 +19407,14 @@ "fsevents": "~2.3.3" }, "peerDependencies": { - "@types/node": "^18.0.0 || ^20.0.0 || >=22.0.0", + "@types/node": "^20.19.0 || >=22.12.0", "jiti": ">=1.21.0", - "less": "*", + "less": "^4.0.0", "lightningcss": "^1.21.0", - "sass": "*", - "sass-embedded": "*", - "stylus": "*", - "sugarss": "*", + "sass": "^1.70.0", + "sass-embedded": "^1.70.0", + "stylus": ">=0.54.8", + "sugarss": "^5.0.0", "terser": "^5.16.0", "tsx": "^4.8.1", "yaml": "^2.4.2" diff --git a/package.json b/package.json index ea07b0e00..239ee50a4 100644 --- a/package.json +++ b/package.json @@ -95,7 +95,7 @@ "ts-morph": "^26.0.0", "tsx": "^4.20.4", "typescript-eslint": "^8.40.0", - "vite": "^6.2.7", + "vite": "^7.1.3", "vite-plugin-checker": "^0.9.1", "vite-plugin-circular-dependency": "^0.5.0", "vite-plugin-dts": "^4.5.3", From d1411af06d5758610d2c6baf1cb557117eeb85e1 Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Tue, 26 Aug 2025 11:13:57 -0700 Subject: [PATCH 2/2] fix: update vite config to support new externalization feature --- package-lock.json | 23 ++++------------- package.json | 1 - .../Compensation/Compensation.test.tsx | 25 +++++++++++++++---- vite.config.ts | 10 ++++++-- 4 files changed, 33 insertions(+), 26 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3cc8f6c3d..5aaab13bc 100644 --- a/package-lock.json +++ b/package-lock.json @@ -64,12 +64,12 @@ "sass-embedded": "^1.90.0", "ts-morph": "^26.0.0", "tsx": "^4.20.4", + "typescript": "^5.9.2", "typescript-eslint": "^8.40.0", "vite": "^7.1.3", "vite-plugin-checker": "^0.9.1", "vite-plugin-circular-dependency": "^0.5.0", "vite-plugin-dts": "^4.5.3", - "vite-plugin-externalize-deps": "^0.9.0", "vite-plugin-stylelint": "^6.0.2", "vite-plugin-svgr": "^4.3.0", "vitest": "^3.2.4" @@ -19038,11 +19038,11 @@ } }, "node_modules/typescript": { - "version": "5.8.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.8.3.tgz", - "integrity": "sha512-p1diW6TqL9L07nNxvRMM7hMMw4c5XOo/1ibL4aAIGmSAt9slTE1Xgw5KWuof2uTOvCg9BY7ZRi+GaF+7sfgPeQ==", + "version": "5.9.2", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.9.2.tgz", + "integrity": "sha512-CWBzXQrc/qOkhidw1OzBTQuYRbfyxDXJMVJ1XNwUHGROVmuaeiEm3OslpZ1RV96d7SKKjZKrSJu3+t/xlw3R9A==", + "devOptional": true, "license": "Apache-2.0", - "peer": true, "bin": { "tsc": "bin/tsc", "tsserver": "bin/tsserver" @@ -19674,19 +19674,6 @@ } } }, - "node_modules/vite-plugin-externalize-deps": { - "version": "0.9.0", - "resolved": "https://registry.npmjs.org/vite-plugin-externalize-deps/-/vite-plugin-externalize-deps-0.9.0.tgz", - "integrity": "sha512-wg3qb5gCy2d1KpPKyD9wkXMcYJ84yjgziHrStq9/8R7chhUC73mhQz+tVtvhFiICQHsBn1pnkY4IBbPqF9JHNw==", - "dev": true, - "license": "MIT", - "funding": { - "url": "https://github.com/sponsors/voracious" - }, - "peerDependencies": { - "vite": "^2.0.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" - } - }, "node_modules/vite-plugin-stylelint": { "version": "6.0.2", "resolved": "https://registry.npmjs.org/vite-plugin-stylelint/-/vite-plugin-stylelint-6.0.2.tgz", diff --git a/package.json b/package.json index 239ee50a4..3b074a9d1 100644 --- a/package.json +++ b/package.json @@ -99,7 +99,6 @@ "vite-plugin-checker": "^0.9.1", "vite-plugin-circular-dependency": "^0.5.0", "vite-plugin-dts": "^4.5.3", - "vite-plugin-externalize-deps": "^0.9.0", "vite-plugin-stylelint": "^6.0.2", "vite-plugin-svgr": "^4.3.0", "vitest": "^3.2.4" diff --git a/src/components/Employee/Compensation/Compensation.test.tsx b/src/components/Employee/Compensation/Compensation.test.tsx index d0e1acc7d..2e3048d4a 100644 --- a/src/components/Employee/Compensation/Compensation.test.tsx +++ b/src/components/Employee/Compensation/Compensation.test.tsx @@ -435,7 +435,10 @@ describe('Compensation', () => { expect(cards).toHaveLength(2) - const primaryJobCard = cards.find(card => card.textContent?.includes('My Job')) + const primaryJobCard = cards.find( + card => card.textContent && card.textContent.includes('My Job'), + ) + expect(primaryJobCard).toBeDefined() const jobActionsControl = within(primaryJobCard!).getByRole('button', { name: 'Job actions', @@ -468,7 +471,10 @@ describe('Compensation', () => { const cards = screen.getAllByTestId('data-card') expect(cards).toHaveLength(2) - const nonPrimaryJobCard = cards.find(card => card.textContent?.includes('An additional job')) + const nonPrimaryJobCard = cards.find( + card => card.textContent && card.textContent.includes('An additional job'), + ) + expect(nonPrimaryJobCard).toBeDefined() const jobActionsControl = within(nonPrimaryJobCard!).getByRole('button', { name: 'Job actions', @@ -500,7 +506,10 @@ describe('Compensation', () => { const cards = screen.getAllByTestId('data-card') expect(cards).toHaveLength(2) - const nonPrimaryJobCard = cards.find(card => card.textContent?.includes('An additional job')) + const nonPrimaryJobCard = cards.find( + card => card.textContent && card.textContent.includes('An additional job'), + ) + expect(nonPrimaryJobCard).toBeDefined() const jobActionsControl = within(nonPrimaryJobCard!).getByRole('button', { name: 'Job actions', @@ -534,7 +543,10 @@ describe('Compensation', () => { const cards = screen.getAllByTestId('data-card') expect(cards).toHaveLength(2) - const primaryJobCard = cards.find(card => card.textContent?.includes('My Job')) + const primaryJobCard = cards.find( + card => card.textContent && card.textContent.includes('My Job'), + ) + expect(primaryJobCard).toBeDefined() const jobActionsControl = within(primaryJobCard!).getByRole('button', { name: 'Job actions', @@ -594,7 +606,10 @@ describe('Compensation', () => { const cards = screen.getAllByTestId('data-card') expect(cards).toHaveLength(2) - const nonPrimaryJobCard = cards.find(card => card.textContent?.includes('An additional job')) + const nonPrimaryJobCard = cards.find( + card => card.textContent && card.textContent.includes('An additional job'), + ) + expect(nonPrimaryJobCard).toBeDefined() const jobActionsControl = within(nonPrimaryJobCard!).getByRole('button', { name: 'Job actions', diff --git a/vite.config.ts b/vite.config.ts index ae3a32276..05db91314 100644 --- a/vite.config.ts +++ b/vite.config.ts @@ -7,7 +7,6 @@ import stylelint from 'vite-plugin-stylelint' import svgr from 'vite-plugin-svgr' import circularDependencyDetector from 'vite-plugin-circular-dependency' import checker from 'vite-plugin-checker' -import { externalizeDeps } from 'vite-plugin-externalize-deps' /** * Current config is set to build sdk in library mode, retaining the original file structure and file names while also allowing for css modules and single css file output. @@ -18,7 +17,6 @@ export default defineConfig(({ mode }) => { return { plugins: [ react(), - externalizeDeps(), // Externalizes all dependencies !isDev && dts({ include: ['src', 'src/types/i18next.d.ts'], @@ -83,6 +81,14 @@ export default defineConfig(({ mode }) => { cssCodeSplit: false, rollupOptions: { input: resolve(__dirname, 'src/index.ts'), + external: id => { + // Externalize all node_modules dependencies + return ( + id.startsWith('node:') || + /^[a-zA-Z][a-zA-Z0-9@\-_/]*$/.test(id) || + id.includes('node_modules') + ) + }, output: { preserveModules: true, preserveModulesRoot: 'src',