Overridden setValue( ) fires events

[mitchmartin]

The documentation of com.google.gwt.user.client.ui.HasValue#setValue(T) states that it should set the value without firing events. However, many of the overridden setValue functions in Material classes that implement this interface do the opposite.

This is true for AbstractValueWidget, MaterialSwitch, (Addins)MaterialComboBox, and MaterialListValueBox

Either these implementations should be fixed to not fire events (as stated by the HasValue interface), or these implementations should be documented such that this is explained.

[tflinz]

Came across this when using MaterialDatePicker (which extends AbstractValueWidget), very confusing and needs to be fixed.

[tflinz]

Another observation, is that even if you do call .setValue(value,false) it still fires an event somewhere under the hood. Or, I am crazy. So if someone else was able to confirm this behaviour, it would be much appreciated.

[kevzlou7979]

@mitchmartin Ok thanks for catching this up. I will do a revision to not fire the event automatically. Will be ready on release 2.0-rc4

[kevzlou7979]

Fixed via a570922

[kevzlou7979]

Reverted this, As we found some major fallbacks on some widgets.
Also I found out the culprit on DatePicker event firing even we call setValue(Value, false) on line https://github.com/GwtMaterialDesign/gwt-material/blob/master/gwt-material/src/main/java/gwt/material/design/client/ui/MaterialDatePicker.java#L270