Gytis Trikleris gytis

Organizations

@jbossas @jbosstm
@gytis
gytis commented on pull request jbosstm/narayana#889
@gytis

Fair enough and I under stand that the reason is trivial. But at the same time all hornetq store classes are in the internal package, which user sh…

gytis commented on pull request jbosstm/narayana#889
@gytis

Well, the store was implemented using Hornetq journal, thus the name made sense. Now the Hornetq journal isn't there any more so the name is mislea…

gytis commented on pull request jbosstm/narayana#889
@gytis

I'm not suggesting to use Artemis name, but use more generic one like JournalStore as Tom suggested. Because in my opinion current name suggests th…

gytis commented on pull request jbosstm/narayana#889
@gytis

There is no benefit in functionality for sure. What I mean it might be clear now what it is, but for somebody in the future might not make any sens…

gytis commented on pull request jbosstm/narayana#889
@gytis

Anyway, I think it is going to be confusing in the future, since HornetQ is not available any more but our store is still called that way.

gytis commented on pull request jbosstm/narayana#889
@gytis

@tomjenkinson , I agree. Name should be more generic in case the journal provider changes again in the future.

gytis commented on pull request jbosstm/narayana#889
@gytis

@mmusgrov , maybe we should look into renaming classes and packages since HornetqJournalStore class is not valid any more?

gytis commented on pull request jbosstm/narayana#889
@gytis

@mmusgrov , was the txbridge test hanging?

@gytis
  • @gytis dcec3d4
    [JBTM-2426] Check if timerTask is not null before calling equals
gytis merged pull request jbosstm/narayana#886
@gytis
[JBTM-2426] Check if timerTask is not null before calling equals
1 commit with 2 additions and 2 deletions
gytis pushed to master at gytis/narayana
@gytis
gytis opened pull request jbosstm/narayana#886
@gytis
[JBTM-2426] Check if timerTask is not null before calling equals
1 commit with 2 additions and 2 deletions
@gytis
  • @gytis 3a43cec
    [JBTM-2456] Bring back maven executable to the repo
gytis merged pull request jbosstm/documentation#33
@gytis
[JBTM-2456] Bring back maven executable to the repo
1 commit with 5,737 additions and 0 deletions
@gytis
gytis opened pull request jbosstm/documentation#33
@gytis
[JBTM-2456] Bring back maven executable to the repo
1 commit with 5,737 additions and 0 deletions
@gytis
gytis merged pull request gytis/ci-report-generator#1
@gytis
Updated to include some more exotic jobs
1 commit with 16 additions and 0 deletions
@gytis
@gytis