New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from Visual Studio project files to CMake #1

Closed
dpogue opened this Issue Apr 7, 2011 · 12 comments

Comments

Projects
None yet
7 participants
@dpogue
Member

dpogue commented Apr 7, 2011

This will also allow generation of Makefiles, XCode projects, and MinGW makefiles.

@branan

This comment has been minimized.

Member

branan commented Apr 17, 2011

This is mostly done at this point - plClient and a couple of other apps are converted, along with the max plugin. Someone should probably play with the remaining apps at some point, just so we can finally close this thing

dpogue added a commit that referenced this issue Feb 13, 2012

@Hoikas

This comment has been minimized.

Member

Hoikas commented Jun 21, 2012

I think the only remaining blocker on this is plSDLBrowser

@branan

This comment has been minimized.

Member

branan commented Jun 21, 2012

Awesome. It'll be nice to finally close #1

@Mystler

This comment has been minimized.

Contributor

Mystler commented Jun 21, 2012

I tried to write a CMake file for it once but I encountered either a problem with missing files or one with outdated code.

@Lunanne

This comment has been minimized.

Member

Lunanne commented Jun 21, 2012

Some of the code files were removed in an old commit as they were unused at the time. I'm planning to try to get it to work later today.

Edit : it seems some files needed were removed for licence issues, namely https://bitbucket.org/Lunanne/cwe-ou/src/d2e5b9c38803/MOULOpenSourceClientPlugin/Plasma20/Sources/Plasma/PubUtilLib/plWndCtrls/basewnd.h

@Deledrius

This comment has been minimized.

Member

Deledrius commented Jul 18, 2012

Did you make any progress on that, @Lunanne, or should I take a stab at it?

@Lunanne

This comment has been minimized.

Member

Lunanne commented Jul 18, 2012

I haven't really looked again, I got distracted and I don't really know enough c++ yet to solve the issue anyway.

@Deledrius

This comment has been minimized.

Member

Deledrius commented Jul 18, 2012

It appears to have been commit 971c39d which removed those files due to a dependency upon a library with no license (at least none that I can see on http://www.mvps.org/user32/), but the plWndCtrls code itself should have been fine...? It seems the code on which it depended was a very simple collection of functions to replace, too, but it was all unused at the time since plSDLBrowser was not active.

Do we even need to resurrect plSDLBrowser? Looking at this thing, it appears pretty simple and ugly, and depends on a load of gunk used nowhere else.

@branan

This comment has been minimized.

Member

branan commented Jul 18, 2012

My thoughts here:

Is there a need for this sort of tool in the community? If so we either need to fix this or write a replacement. If there's no present need it should be trashed and only looked at again if we have a need that this tool (or something like it) could fill.

@branan branan closed this Jul 18, 2012

@branan branan reopened this Jul 18, 2012

@branan

This comment has been minimized.

Member

branan commented Jul 18, 2012

gah, freeking close and comment is not awesome on un-css'd browsers :(

@Lunanne

This comment has been minimized.

Member

Lunanne commented Jul 18, 2012

I'm currently trying to get the project to build to see what it exactly does, probably anyone else can do this a lot faster than me but it is a good exercise.

@Lyrositor

This comment has been minimized.

Member

Lyrositor commented Nov 10, 2012

IRC discussion has led to the consensus that plSDLBrowser should be tossed, because it is useless as it is and can't work because of removed copyrighted Microsoft code. I'll try to make a PR removing it.

Deledrius pushed a commit to Deledrius/Plasma that referenced this issue Dec 4, 2012

boq pushed a commit to boq/Plasma that referenced this issue Dec 15, 2012

@Hoikas Hoikas closed this in a3ecf38 Feb 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment