Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang warning and missing include #1003

Merged
merged 2 commits into from Oct 9, 2021
Merged

Fix clang warning and missing include #1003

merged 2 commits into from Oct 9, 2021

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 9, 2021

  • Clang was warning about std::unique_ptr<plAudioEndpointVolume> calling the non-virtual destructor
  • When building with unified sources disabled, plPageTreeMgr.h ran into errors about size_t not being defined

@Hoikas Hoikas merged commit 5b68769 into H-uru:master Oct 9, 2021
@dpogue dpogue deleted the clang-fixes branch November 2, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpogue @Hoikas