Fix #170 #205

Merged
merged 1 commit into from May 9, 2012

Conversation

Projects
None yet
3 participants
Member

Lyrositor commented May 8, 2012

This closes #170. I have tested this on my own shard with an internal client. I have also thrown in a bit of more "correct" XHTML tags, just to avoid obsoletion in 2999.

Sources/Plasma/FeatureLib/pfConsoleCore/pfConsoleCmd.cpp
@@ -565,7 +565,7 @@ uint8_t pfConsoleCmd::GetSigEntry( uint8_t i )
const char *pfConsoleCmd::GetSignature( void )
{
- static char string[ 256 ];
+ char* string = new char[256];
@branan

branan May 8, 2012

Owner

I think the correct fix here is just char string[256];. This will be allocated on the stack each call (so it won't be shared), but it won't cause a leak.

Member

Lyrositor commented May 8, 2012

I've switched to your suggestion, branan.

Hoikas added a commit that referenced this pull request May 9, 2012

@Hoikas Hoikas merged commit 56994f2 into H-uru:master May 9, 2012

Deledrius pushed a commit to Deledrius/Plasma that referenced this pull request Dec 4, 2012

Hoikas added a commit to Hoikas/Plasma that referenced this pull request Dec 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment