Fix crash triggered by clients sending too-new SDL.#156
Merged
zrax merged 1 commit intoH-uru:masterfrom Oct 6, 2021
Merged
Conversation
Deledrius
approved these changes
Oct 6, 2021
If someone is hacking, developing, etc., then they may have an SDL descriptor that is newer than what the server knows about. This is most likely to happen for Age SDL (eg Personal, Kveer, etc). The client blindly updates any out of date Age Vault SDL that it finds to whatever it thinks the most recent descriptor is. This fixes the DS vault SDL merging code to be more selective and not crash when receiving an "invalid" SDL blob. To reproduce, open the Personal.sdl file in your client, copy the last STATEDESC, and increment its version.
zrax
approved these changes
Oct 6, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If someone is hacking, developing, etc., then they may have an SDL descriptor that is newer than what the server knows about. This is most likely to happen for Age SDL (eg Personal, Kveer, etc). The client blindly updates any out of date Age Vault SDL that it finds to whatever it thinks the most recent descriptor is. This fixes the DS vault SDL merging code to be more selective and not crash when receiving an "invalid" SDL blob.
To reproduce, open the Personal.sdl file in your client, copy the last STATEDESC, and increment its version.