Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI. #157

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix CI. #157

merged 1 commit into from
Oct 6, 2021

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Oct 6, 2021

No description provided.

@Hoikas Hoikas force-pushed the fix_ci branch 2 times, most recently from 2543c18 to 450303b Compare October 6, 2021 02:17
- GitHub no longer offers Ubuntu 16.04 runners.
- Change from `apt` to `apt-get` to fix warning.
- Remove install of broken package `postgresql-server-dev-all`.
@Hoikas Hoikas marked this pull request as ready for review October 6, 2021 02:19
@@ -12,14 +12,14 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-16.04, ubuntu-18.04]
os: [ubuntu-18.04, ubuntu-20.04]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particularly compelling reason to test on multiple Ubuntu versions instead of ubuntu-latest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question I will defer to @zrax, but I know he generally seems to want stuff to work all the way back to the previous ubuntu LTS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that has been my general goal in the past, after we did end up breaking something for someone using an old LTS one time... As long as it's not unreasonable to do so, I think it's still a good goal.

@zrax zrax merged commit 99d558a into H-uru:master Oct 6, 2021
@Hoikas Hoikas deleted the fix_ci branch October 6, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants