Fix CI.#157
Merged
Merged
Conversation
Hoikas
force-pushed
the
fix_ci
branch
2 times, most recently
from
2543c18 to
450303b
Compare
- GitHub no longer offers Ubuntu 16.04 runners. - Change from `apt` to `apt-get` to fix warning. - Remove install of broken package `postgresql-server-dev-all`.
dpogue
reviewed
Oct 6, 2021
| strategy: | ||
| matrix: | ||
| os: [ubuntu-16.04, ubuntu-18.04] | ||
| os: [ubuntu-18.04, ubuntu-20.04] |
Member
There was a problem hiding this comment.
Is there a particularly compelling reason to test on multiple Ubuntu versions instead of ubuntu-latest?
Member
Author
There was a problem hiding this comment.
Good question I will defer to @zrax, but I know he generally seems to want stuff to work all the way back to the previous ubuntu LTS.
Member
There was a problem hiding this comment.
Yes, that has been my general goal in the past, after we did end up breaking something for someone using an old LTS one time... As long as it's not unreasonable to do so, I think it's still a good goal.
dpogue
approved these changes
Oct 6, 2021
zrax
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.