Add missing server messages #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ironically, |
zrax
reviewed
Oct 19, 2021
Member
zrax
left a comment
zrax
left a comment
There was a problem hiding this comment.
Good catch!
Please also add the appropriate wrapper function and callback plumbing to pnAuthClient, so these can be used.
roblabla
force-pushed
the
missing-msgs
branch
2 times, most recently
from
37a90a2 to
1204fa8
Compare
zrax
reviewed
Oct 20, 2021
roblabla
force-pushed
the
missing-msgs
branch
from
1204fa8 to
e97d740
Compare
roblabla
force-pushed
the
missing-msgs
branch
from
e97d740 to
5630eb3
Compare
Contributor
Author
|
All fixed. Sorry for the long wait. |
roblabla
force-pushed
the
missing-msgs
branch
from
5630eb3 to
650ed7c
Compare
zrax
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libhsplasmanet is missing three messages from H-uru/Plasma: kCli2Auth_ScoreGetHighScores, kAuth2Cli_ScoreGetHighScoresReply and kAuth2Cli_ServerCaps. The later one in particular prevents it from connecting to dirtsand servers, breaking tools like MoulKI. This MR implements all three, which fixes the issue.