Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing server messages #229

Merged
merged 3 commits into from Oct 29, 2021
Merged

Add missing server messages #229

merged 3 commits into from Oct 29, 2021

Conversation

roblabla
Copy link
Contributor

libhsplasmanet is missing three messages from H-uru/Plasma: kCli2Auth_ScoreGetHighScores, kAuth2Cli_ScoreGetHighScoresReply and kAuth2Cli_ServerCaps. The later one in particular prevents it from connecting to dirtsand servers, breaking tools like MoulKI. This MR implements all three, which fixes the issue.

@dpogue
Copy link
Member

dpogue commented Oct 19, 2021

Ironically, kAuth2Cli_ServerCaps is a H'uru invention that is only supported by Dirtsand 😛

Copy link
Member

@zrax zrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Please also add the appropriate wrapper function and callback plumbing to pnAuthClient, so these can be used.

@roblabla roblabla force-pushed the missing-msgs branch 2 times, most recently from 37a90a2 to 1204fa8 Compare October 20, 2021 17:31
net/auth/pnAuthClient.cpp Outdated Show resolved Hide resolved
net/auth/pnAuthClient.h Outdated Show resolved Hide resolved
net/auth/pnAuthClient.cpp Outdated Show resolved Hide resolved
@roblabla
Copy link
Contributor Author

All fixed. Sorry for the long wait.

@zrax zrax merged commit 5bdde95 into H-uru:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants