Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentence containing percent symbol in King Hemelin notebook #88

Merged
merged 1 commit into from Oct 27, 2021

Conversation

dgelessus
Copy link
Contributor

One sentence in the King Hemelin notebook was partially destroyed at some point, apparently as the result of a regex replace gone wrong. Someone replaced "%.*s" with "%256s", probably meaning to adjust some printf-style format strings, but this accidentally also matched a literal percent symbol in the King Hemelin notebook and deleted some of the following words.

In the English version, someone apparently noticed this and removed the destroyed part of the sentence, but did not fully undo the incorrect change. The French and German translations were never fixed.

This commit fully restores the sentence, based on the text from Uru CC, where it was not yet broken. The English original and French and German translations are fixed (there is no Italian or Spanish translation for this notebook).

One sentence in the King Hemelin notebook was partially destroyed at
some point, apparently as the result of a regex replace gone wrong.
Someone replaced "%.*s" with "%256s", probably meaning to adjust some
printf-style format strings, but this accidentally also matched a
literal percent symbol in the King Hemelin notebook and deleted some of
the following words.

In the English version, someone apparently noticed this and removed the
destroyed part of the sentence, but did not fully undo the incorrect
change. The French and German translations were never fixed.

This commit fully restores the sentence, based on the text from Uru CC,
where it was not yet broken. The English original and French and German
translations are fixed (there is no Italian or Spanish translation for
this notebook).
@Hoikas Hoikas added bug Something isn't working objective An issue or fix that is a clear defect or improvement labels Oct 27, 2021
@Hoikas Hoikas merged commit 906e9c2 into H-uru:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working objective An issue or fix that is a clear defect or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants