Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the issue number 'Fix' format in pull request #58

Closed
kdestasio opened this issue Aug 9, 2018 · 2 comments · Fixed by #65

Comments

@kdestasio
Copy link
Contributor

commented Aug 9, 2018

Describe the bug
It is not clear that the issue number needs to go next to 'Fix #' without a space in the text of a pull request.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. use option '...'
  3. See error

Expected behavior
Add instructions to the pull request template that indicate the # and issue number are not separated by a space.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
    n/a
    nibetaseries version
    Add the version of nibetaseries you are using
    n/a
    Additional context
    Add any other context about the problem here.
    n/a

@jdkent jdkent added this to To do in nhw-hackathon via automation Aug 9, 2018

@kristianeschenburg

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2018

I'll look at this issue.

@jdkent

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

Thanks for bringing up this issue @kdestasio! Would changing Fixes # . to Fixes #<NUM>. (e.g. Fixes #58.) clarify the template?

nhw-hackathon automation moved this from To do to Done Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.