From b35c9063c6e5bd105089c27b27f522296b9f4446 Mon Sep 17 00:00:00 2001
From: lukemartinlogan <lukemartinlogan@gmail.com>
Date: Mon, 28 Nov 2022 03:44:59 -0600
Subject: [PATCH] Fix doxygen warnings

---
 .../adapter_generator/create_interceptor.py                  | 1 +
 adapter/filesystem/filesystem.h                              | 5 +++++
 adapter/mpiio/real_api.h                                     | 1 +
 adapter/posix/real_api.h                                     | 1 +
 adapter/stdio/real_api.h                                     | 1 +
 src/api/vbucket.h                                            | 5 +++--
 6 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/adapter/adapter_generator/adapter_generator/create_interceptor.py b/adapter/adapter_generator/adapter_generator/create_interceptor.py
index 28fa61db4..2a7d4033e 100644
--- a/adapter/adapter_generator/adapter_generator/create_interceptor.py
+++ b/adapter/adapter_generator/adapter_generator/create_interceptor.py
@@ -156,6 +156,7 @@ def _CreateH(self, namespace, includes, path):
         # Create the class definition
         self.h_lines.append(f"namespace hermes::adapter::{namespace} {{")
         self.h_lines.append(f"")
+        self.h_lines.append(f"/** Pointers to the real {namespace} API */")
         self.h_lines.append(f"class API {{")
 
         # Create class function pointers
diff --git a/adapter/filesystem/filesystem.h b/adapter/filesystem/filesystem.h
index ef91b3fcc..dc7741303 100644
--- a/adapter/filesystem/filesystem.h
+++ b/adapter/filesystem/filesystem.h
@@ -201,6 +201,11 @@ struct IoOptions {
     return opts;
   }
 
+  /**
+   * Ensure that I/O goes only to Hermes, and does not fall back to PFS.
+   *
+   * @param orig_opts The original options to modify
+   * */
   static IoOptions PlaceInHermes(IoOptions &orig_opts) {
     IoOptions opts(orig_opts);
     opts.seek_ = false;
diff --git a/adapter/mpiio/real_api.h b/adapter/mpiio/real_api.h
index 90fbfdb91..93a601367 100644
--- a/adapter/mpiio/real_api.h
+++ b/adapter/mpiio/real_api.h
@@ -62,6 +62,7 @@ typedef int (*MPI_File_sync_t)(MPI_File fh);
 
 namespace hermes::adapter::mpiio {
 
+/** Pointers to the real mpiio API */
 class API {
  public:
   /** MPI_Init */
diff --git a/adapter/posix/real_api.h b/adapter/posix/real_api.h
index a1f87ca47..6dc719972 100644
--- a/adapter/posix/real_api.h
+++ b/adapter/posix/real_api.h
@@ -54,6 +54,7 @@ typedef int (*close_t)(int fd);
 
 namespace hermes::adapter::posix {
 
+/** Pointers to the real posix API */
 class API {
  public:
   /** MPI_Init */
diff --git a/adapter/stdio/real_api.h b/adapter/stdio/real_api.h
index c3d791ad4..7fceff47e 100644
--- a/adapter/stdio/real_api.h
+++ b/adapter/stdio/real_api.h
@@ -61,6 +61,7 @@ typedef long int (*ftell_t)(FILE * fp);
 
 namespace hermes::adapter::stdio {
 
+/** Pointers to the real stdio API */
 class API {
  public:
   /** MPI_Init */
diff --git a/src/api/vbucket.h b/src/api/vbucket.h
index 9b7216381..00af5df64 100644
--- a/src/api/vbucket.h
+++ b/src/api/vbucket.h
@@ -163,9 +163,10 @@ class VBucket {
   size_t Get(const std::string &name, Bucket *bkt, void *user_blob,
              size_t blob_size, const Context &ctx);
 
-  /** retrieves the subset of blob links satisfying pred */
-  /** could return iterator */
+  /** retrieves all blob links */
   std::vector<std::string> GetLinks();
+
+  /** retrieves all blob links subject to a predicte in \a ctx */
   std::vector<std::string> GetLinks(Context &ctx);
 
   /** \brief Attach a Trait to this VBucket.