Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux Build/Install/Test CI, Docs, and Coding Standard Script #8

Merged
merged 158 commits into from
Jul 20, 2021

Conversation

kencasimiro
Copy link
Contributor

  • Documentation completed for ReadtheDocs
  • Coding Standard GitHub Actions completed
  • Linux build/install/test CI completed

@sbyna sbyna requested a review from houjun July 20, 2021 15:27
Copy link
Collaborator

@houjun houjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencasimiro, I just formatted the codes under src and tests with your clang-format file, can you rebase this pull request on the latest develop branch?

.clang-format Outdated
- Regex: '.*'
Priority: 0
SortPriority: 0
- Regex: '^PDC*.*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

Removed the following:
  - Regex:           '.*'
    Priority:        0
    SortPriority:    0
  - Regex:           '^PDC*.*'
    Priority:        1
    SortPriority:    0
Copy link
Collaborator

@houjun houjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @kencasimiro !

@houjun houjun merged commit 2fd34b2 into HDFGroup:develop Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants