Not all dependencies are included in the setup.py

[bhazelton]

One of our undergrads stumbled on this. In particular bokeh is not listed in the setup.py but is imported at the top of utils.py. I haven't checked if there are other requirements that are not listed.

A side note -- the imports in that file are difficult to read. There are recommended structures for imports, see e.g. https://www.python.org/dev/peps/pep-0008/#imports

[jsdillon]

@HonggeunKim I think that was you. Can you take care of this?

[HonggeunKim]

@jsdillon Yes I think it is me. bokeh is a python package to make an interactive plot for delay spectra. Do I need to add bokeh in 'install_requires' of setup.py or should I do something else?

[PyxieLouStar]

We're also getting an import error for healpy. Running from hera_notebook_templates import utils gives the print message could not import sklearn, but does not throw an error so it isn't clear if the sklearn package is actually required.

[bhazelton]

We should avoid using healpy, it's licensed under the GPL license, which is a copy left license and is not compatible with our licensing policies. The astropy_healpix package should be used instead.

[HonggeunKim]

@jsdillon I added 'bokeh' and 'multiprocessing' to the 'linstall_requires' list of setup.py file and directly committed it to the master branch

[jsdillon]

ok, thanks!

[bhazelton]

I'm not sure this should be closed. Healpy is still not listed in the setup.py but is imported at the top of utils.py. I also don't think we should be importing it under the license of this repo.

[jsdillon]

@dstorer Looks like its just your code that uses healpy. How hard would it be to change it to astropy-healpix?