Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call to run_with_profiling #263

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: call to run_with_profiling #263

merged 1 commit into from
Jul 6, 2023

Conversation

steven-murray
Copy link
Contributor

This fixes the call to run_with_profiling in hera-sim-vis.py.

@steven-murray steven-murray self-assigned this Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bfcc62c) 92.95% compared to head (d58f250) 92.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files          24       24           
  Lines        3209     3209           
  Branches      705      705           
=======================================
  Hits         2983     2983           
  Misses        123      123           
  Partials      103      103           
Flag Coverage Δ
unittests 92.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@piyanatk piyanatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Haha. This is super simple. I tried to read through hera_cli code but couldn't figure out what was wrong ... maybe I was sleepy. Thanks for the fix @steven-murray .

@steven-murray steven-murray merged commit a5f85e3 into main Jul 6, 2023
8 checks passed
@steven-murray steven-murray deleted the fix-hera-sim-vis branch July 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants