Skip to content
Browse files

Stop stripping out the "default" sound from APNS objects, because sen…

…ding that

is Apple's recommended way of requesting the default notification sound. If
you omit it, then no sound at all is played.
  • Loading branch information...
1 parent 30efe2d commit c0cfa270b7c8cfdcf97eafb64b3119800e620c74 @brunchboy brunchboy committed Sep 25, 2012
Showing with 6 additions and 9 deletions.
  1. +3 −6 src/herolabs/apns/message.clj
  2. +3 −3 test/herolabs_test/apns/message.clj
View
9 src/herolabs/apns/message.clj
@@ -4,11 +4,7 @@
(defn with-badge [message number] (assoc-in message [:aps :badge ] number))
(defn with-sound [message sound]
- (cond
- (= :default sound) (update-in message [:aps ] #(dissoc % :sound ))
- (= "default" sound) (update-in message [:aps ] #(dissoc % :sound ))
- :else (assoc-in message [:aps :sound ] sound)
- )
+ (assoc-in message [:aps :sound ] (name sound))
)
(defn with-standard-alert [message body]
@@ -44,4 +40,5 @@
(if key
(assoc-in message [:aps :alert :body ] body)
message)
- )
+ )
+
View
6 test/herolabs_test/apns/message.clj
@@ -7,9 +7,9 @@
(facts "about message assembly"
(with-badge {} 1) => (just {:aps {:badge 1}})
- (with-sound {} :default) => (just {:aps nil})
- (with-sound {} "default") => (just {:aps nil})
- (with-sound {} :chimes) => (just {:aps {:sound :chimes}})
+ (with-sound {} :default) => (just {:aps {:sound "default"}})
+ (with-sound {} "default") => (just {:aps {:sound "default"}})
+ (with-sound {} :chimes) => (just {:aps {:sound "chimes"}})
(with-standard-alert {} "Hello world") => (just {:aps {:alert "Hello world"}})
(with-action-loc-key {} "TEST") => (just {:aps {:alert {:action-loc-key "TEST"}}})
(with-loc-key {} "TEST") => (just {:aps {:alert {:loc-key "TEST"}}})

0 comments on commit c0cfa27

Please sign in to comment.
Something went wrong with that request. Please try again.