Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stall horn test and prepared icing #256

Merged
merged 11 commits into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@hbeni
Copy link
Collaborator

commented Feb 11, 2018

This adds:

  • stall horn function dependency on active breaker and electrical power (see POH 7-47)
  • stall horn test switch property to test the horn on the ground
  • prepared stall horn icing (piggybag on pitot icing)
  • stall horn can theoretically fail now (/controls/stall-horn/serviceable -> false)

Open:

  • add exterior clickspot (only in .ac file currently)
    • verify blender model
  • add texture
  • add checklist item to preflight (left wing leading edge / POH 4-11) (was already there)

image

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 11, 2018

@HHS81 It would be cool if you could add a suitable clickspot (or even model?) to the wing so we can test the stall horn in preflight. The Property is /controls/stall-horn/test.

Once we have merged this, we can also merge it into the pitot icing branch and enable the icing feature (just comment out the prepared code in c182-sound.xml)

Some related pics:
Stall Horn Position
Stall Horn closeup

@HHS81

This comment has been minimized.

Copy link
Owner

commented Feb 11, 2018

@hbeni
after responding to a lot of things from you I take a break and concentrate on my things here again. Especially as my PRs have been again ignored to be merged. And I didn't find time to finish the icing feature yet.
So this PR here have to wait until I have finished all my recent open Issues!

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 11, 2018

No rush!
Glad to hear that your windows issues are solved (are they?)

I am not familiar with the merge policy in this project and currently think, that you should have the last word on merging at least for non trivial things, including your own pull requests. Would you like to handle it differently, esp. do you want (for example) me to review and merge your (and also mine) requests?

(I just dont dared to merge your stuff)

@HHS81

This comment has been minimized.

Copy link
Owner

commented Feb 11, 2018

@hbeni
Usually I follow the same rules like the c172p does: Peer-Review.
That means someone creates a PR, and the other members check if there are any issues.
4 eyes sees more issues/ problems than just 2. I found it quite helpfull in the past.
I thought that was clear. 😕

And it seems my computer issues are solved - runs better than before. Must change my virusscanner sometime....

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2018

New stall vane on livery:
image

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2018

Ok, now waiting for the external clickspot, then we are ready.

@HHS81 Should i prepare in the clickspot in the .ac file and you port it over if you get time? Or if i change the blend file, how can i generate the .ac file from it?

@HHS81

This comment has been minimized.

Copy link
Owner

commented Feb 13, 2018

Don't get me wrong: it is basic knowledge how to alter and modify a .blend-file and export it to .ac-file. But if you don' t know how it works, it is better you wait with any 3d-work until I find some time this week! There is no rush, no Deadline, it is not a commercial project and no User pays us any money.

@hbeni hbeni referenced this pull request Feb 13, 2018

Closed

icing effect using multiple dirt texture #144

6 of 6 tasks complete
@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2018

No problem, i just fear to break the main model. I already introduced you hours of unneeded work, so i better wait :) (im not entirely sure what layers to export to the .ac)
My comment served just as some sort of "i'm ready"-flag.

@gilbertohasnofb

This comment has been minimized.

Copy link
Collaborator

commented Feb 13, 2018

@hbeni

New stall vane on livery

That's cool, thanks for adding this! Is this already working with all liveries or will I need to manually add to the other ones?

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2018

@gilbertohasnofb No, i added it to all liverys and also the normalmap. I also updated (and already published) the c182-Textures repo; so this should be ok.

@gilbertohasnofb

This comment has been minimized.

Copy link
Collaborator

commented Feb 13, 2018

I also updated (and already published) the c182-Textures repo; so this should be ok.

That's perfect, many thanks

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 16, 2018

@HHS81 In 124233e i tried to add the clickspot to the model (hope i did it right).
However if i try to export the exterior model, i get only 2.1MB instead of the expected 2.7; and also flightgear quits with a segfault.

I activated all layers from the left box and then selected all the visible objects using border-select. I only activated the "selection only" option from the blender AC-Export menu.

What am i doing wrong?


When i open the current .ac file and port the clickspot over from the blend file, and then export, all seems fine (even with only 2.1MB exported file size!); (this is the current state of the branch so it is basically merge-ready - however, i surely want to learn what i do wrong with the export, so i can assist better in the future)

@HHS81

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2018

@hbeni

What am i doing wrong?

Not listen to me:

But if you don' t know how it works, it is better you wait with any 3d-work until I find some time this week! There is no rush, no Deadline, it is not a commercial project and no User pays us any money.

Then:

so i can assist better in the future

I don't need any assistence in 3-modelling.

You might find me now quite arrogant, but this are those things which costs me most of the time- reviewing and explaining. Time which I could spend on other things on this project.

Honestly said I don't like the way this project is going!

The project started years ago in semester breaks, when I actually had some time left, originally as practice in 3d-modelling, texturing and rendering and with that as a completely private project. I never thought that I will publish it, until Gilberto came up on the forum and I offered the model to FlightGear.
Work could be mostly only done in semester breaks, since I spend every second weekend financing study by working in my previous job, and the other weekend I was happy to get some free time for me.
Yep, studying as an 30+ old man can be hard.

FlightGear is a project which was and is developed in free time, without any payment. It isn't commercial and so this project here it is. The Cessna 182S should have been always be a fun project for me. Yes, aiming for realism - but always in a balance with other things in life, and especially in balance with what is possible and what is useful in FlightGear- pain-to-gain ratio.
Now more and more I feel under pressure; don't find time for my other FlightGear projects like the Dornier 328, EC135 or the BO105.

I don' mind help by others in developing aircraft, quite in the opposite I'm happy that teamwork is easier and I can see it is commonly now accepted in FlightGear. Other then like years ago...

But when a house in real life is built, you won't see a plumper raising the roof; and the elctrician won't build up the walls.
Imagine what would happen in real-life if it wouldn't be like that?

I'm a strong 3d-modeller, have some basic knowledge in texturing and some minor to basic knowledge in coding nasal scripts. Gilberto has a lot of strength in texturing and creating sounds, while you are very strong in coding.

Let's keep it to that; and slow down a lot. Rome wasn't built in one day and so this aircraft.

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 18, 2018

@HHS81 sorry that i made you feel pressurized by me. It is not my intend. I'm just curious how those things work and want to learn, especially in areas where i have no idea about, like kodelling and texturing.

It is perfectly fine for me what you have written and i can understand your toughts. I wil try to lessen my urge.
If i open issues or pull requests, or mention you, please dont think i need immediate attention. I mostly do this so it does not get forgotten and can be picked up easily in the future.

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2018

@HHS81 hello Heiko,
with failures merged now, it would be very cool to also have the stall vane testable in preflight.
All needed for merge is that you check my modified blender model...

Do you think you can split off some minutes for his somewhere soon?

@HHS81

This comment has been minimized.

Copy link
Owner

commented Oct 8, 2018

I will take a look this week, I think I will find some time.

Saving the Blend-file as legacy-format, so it can be opened with olde…
…r Blender versions without any errors

Signed-off-by: Heiko Schulz <Heiko.H.Schulz@gmx.net>
@HHS81

This comment has been minimized.

Copy link
Owner

commented Oct 11, 2018

@hbeni
I have reviewed the .blend-file.
I saved it as Legacy-format. So it can be opened with older Blender-Versions as well without any errors, and the size of the file much smaller.

@HHS81

This comment has been minimized.

Copy link
Owner

commented Oct 11, 2018

So it will be merged.

@HHS81 HHS81 merged commit 0e67be1 into master Oct 11, 2018

@hbeni

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 15, 2018

Thank you very much!
So my blender version is too old?

@HHS81

This comment has been minimized.

Copy link
Owner

commented Oct 15, 2018

@hbeni
nope.
Blender 2.50 and newer saves much more information then we actually need for FlightGear. Especially the Ngons can`t be read by older Blender versions, so models exported from 2.50+ to Blender 2.49 will have edges only, but no faces.

hbeni added a commit that referenced this pull request Oct 15, 2018

@HHS81 HHS81 deleted the stallWarningElec branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.