Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for two bugs that prevents users from transfering larger amounts #140

Closed
wants to merge 3 commits into from
Closed

Conversation

TxbitExchange
Copy link

Please make sure you checked the box ('x') before creating the pull request.

  • I have tested my changes.
  • I have made sure my branch is rebased. it has no merge commits nor stray commits from other people.
  • [-] I have taken the base code from the dev branch, v0.11.3

(taken from master branch)


Description (what did you change?)

Fixed bug in RPC that limits amounts to 21M
Remove invalid money range check that limits outputs to MAX_MONEY


Related github issues (if there are any)


Notes

No consensus changes, no hard-fork required

@FreeTrade
Copy link
Collaborator

I wonder if this is actually a hard fork - if some nodes accept trxs with 60M+ txs and some don't, I fear there would be a chain split. Thoughts?

@TxbitExchange
Copy link
Author

I wonder if this is actually a hard fork - if some nodes accept trxs with 60M+ txs and some don't, I fear there would be a chain split. Thoughts?

The current code accepts 60M+ transactions, so it would not be a hard fork. We were able to successfully test a 60M+ transaction and it did not cause a fork.

@FreeTrade
Copy link
Collaborator

That's reassuring, could you give me the txid of that transaction

@TxbitExchange
Copy link
Author

TxbitExchange commented Apr 24, 2022

That's reassuring, could you give me the txid of that transaction

I will send you the txid after the weekend. Our exchange had a 60M+ deposit. Block synchronization continued, validating the block that contained then 60M+ transaction. The only effect was that it could not make new transactions (sendtoaddress), or for example, request the balance (getbalance). The MAX_MONEY figure is apparently not part of the consensus checks.

@FreeTrade
Copy link
Collaborator

I will send you the txid after the weekend.

Thanks, I think this is probably fine, but I'd like to just verify that txid before committing the pull request.

@TxbitExchange TxbitExchange closed this by deleting the head repository Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants