Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort another hash iterator #54

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@bmwiedemann
Copy link
Contributor

commented Jun 11, 2019

Sort another hash iterator
to produce stable output.

Without this patch, HSAILItems_gen.hpp
got variations in the order of BrigAluModifier and BrigExecutableModifier

Similar to commit 91669c2
for reproducible builds.

I think, I did not notice it back then, because it is just 1 bit of entropy,
so 50% of the time, you can get 2 identical builds.

Sort another hash iterator
to produce stable output.

Without this patch, HSAILItems_gen.hpp
got variations in the order of BrigAluModifier and BrigExecutableModifier

Similar to commit 91669c2
for reproducible builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.