New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerise html proofing and fix broken links #162

Merged
merged 3 commits into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@graeme-a-stewart
Member

graeme-a-stewart commented Sep 23, 2017

Use a container for testing HTML links. This uses a slightly modified version of the jekyll/jekyll container, which is based on Alpine Linux.

(Once this works we should add the Dockerfile somewhere.)

graeme-a-stewart added some commits Sep 12, 2017

Do not use url-ignore list anymore
See instructions in file for how to add the data-proofer-ignore tag
to any URLs that need it

@graeme-a-stewart graeme-a-stewart requested review from jouvin and hegner Sep 23, 2017

@hegner

Sorry, you added two unrelated changes to your PR. Can you remove them?

@graeme-a-stewart

This comment has been minimized.

Show comment
Hide comment
@graeme-a-stewart

graeme-a-stewart Sep 25, 2017

Member

Hi @hegner

Thanks for checking. Just to clarify the changes, which are actually all related to getting a clean html-proof run. In a4e8c8f there is:

  • _gsocproposals/proposal_TMVAmlr.md - add data-proofer-ignore to the two oproject.org URLs which are really slow and give timeouts
  • forum_ml.md - fix machine learning URLs (they changed website layout)
  • forums.md - ditto, and restore LF line endings that were accidentally switched to CRLF in commit 9c67994 by @jouvin (which makes the diff look too big)
  • gsoc/project_SixTrack.md - remove broken links as http://lipforge.ens-lyon.fr/ got decommissioned and all the SVN projects were rehomed

Of course, I can separate the PR into the technical changes and the fixups if you prefer (but note they are separated commits already).

Let me know if you'd still like this modified.

P.S. I will also now squash the travis.yml intermediate attempts to make for a cleaner history

Member

graeme-a-stewart commented Sep 25, 2017

Hi @hegner

Thanks for checking. Just to clarify the changes, which are actually all related to getting a clean html-proof run. In a4e8c8f there is:

  • _gsocproposals/proposal_TMVAmlr.md - add data-proofer-ignore to the two oproject.org URLs which are really slow and give timeouts
  • forum_ml.md - fix machine learning URLs (they changed website layout)
  • forums.md - ditto, and restore LF line endings that were accidentally switched to CRLF in commit 9c67994 by @jouvin (which makes the diff look too big)
  • gsoc/project_SixTrack.md - remove broken links as http://lipforge.ens-lyon.fr/ got decommissioned and all the SVN projects were rehomed

Of course, I can separate the PR into the technical changes and the fixups if you prefer (but note they are separated commits already).

Let me know if you'd still like this modified.

P.S. I will also now squash the travis.yml intermediate attempts to make for a cleaner history

@graeme-a-stewart graeme-a-stewart changed the title from [WIP] Dockerise html proofing to Dockerise html proofing and fix broken links Sep 25, 2017

@hegner

hegner approved these changes Sep 25, 2017

@hegner

This comment has been minimized.

Show comment
Hide comment
@hegner
Member

hegner commented Sep 25, 2017

@hegner hegner merged commit be4a140 into HSF:master Sep 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@graeme-a-stewart graeme-a-stewart deleted the graeme-a-stewart:dockerise-html-proofing branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment