Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding list of Schools in training page #477

Merged
merged 26 commits into from Mar 7, 2019

Conversation

Projects
None yet
4 participants
@GuillermoFidalgo
Copy link
Contributor

GuillermoFidalgo commented Feb 4, 2019

No description provided.

@JavierCVilla JavierCVilla requested a review from graeme-a-stewart Feb 4, 2019

@GuillermoFidalgo

This comment has been minimized.

Copy link
Contributor Author

GuillermoFidalgo commented Feb 5, 2019

Let me know what needs to be fixed.

@graeme-a-stewart
Copy link
Member

graeme-a-stewart left a comment

Hi @GuillermoFidalgo

Thanks - I really like this idea of having a list of schools that everyone can add to. The only thing you need to look out for is that these posts generate accessible pages. So you need a bit of content that is simply a link out to the main school page. e.g., see

https://raw.githubusercontent.com/HSF/hsf.github.io/master/announcements/_posts/2019-02-04-analysis.md

Otherwise, good job!

Show resolved Hide resolved Schools/_posts/2018-09-25-AEPSHEP.md
Show resolved Hide resolved Schools/_posts/2019-02-01-CMS-SHERPA.md Outdated
Show resolved Hide resolved Schools/_posts/2019-02-02-Trans-Siberian-School.md Outdated
Show resolved Hide resolved Schools/_posts/2019-02-03-Summer-CTEQ-School.md Outdated
Show resolved Hide resolved Schools/_posts/2019-03-13-Latin-American-School.md Outdated
Show resolved Hide resolved Schools/_posts/2019-06-02-INFN_School.md Outdated
Show resolved Hide resolved Schools/_posts/2019-08-28-14th-CERN-Fermilab-HCPSS.md Outdated
Show resolved Hide resolved Schools/_posts/2019-09-01-European-School.md Outdated
@graeme-a-stewart

This comment has been minimized.

Copy link
Member

graeme-a-stewart commented Feb 5, 2019

You could also add a new page, just for listing training schools and events (say Schools/events.md) that contains these posts (in the same way that you did on the training page).

Then we can link to that page from the "Communication" drop down menu (see _includes/navbar.ext for how to do that).

GuillermoFidalgo added some commits Feb 7, 2019

@GuillermoFidalgo

This comment has been minimized.

Copy link
Contributor Author

GuillermoFidalgo commented Feb 7, 2019

I think I have made the necessary fixes. Let me know if there is some detail I've missed.

GuillermoFidalgo added some commits Feb 7, 2019

Merge pull request #1 from HSF/master
Sync with upstream repo
@GuillermoFidalgo

This comment has been minimized.

Copy link
Contributor Author

GuillermoFidalgo commented Feb 24, 2019

Hey @graeme-a-stewart I think I have made the necessary changes but I dont quite understand why it says "All checks have failed". I have a lot of content that is ready to be pushed. Let me know if I missed something. Many thanks
-Guillermo

GuillermoFidalgo and others added some commits Feb 24, 2019

Remove "News" from the title (was "HEP Software Foundation News") (#521
)

Remove "News" from the title (was "HEP Software Foundation News")
Minutes of Feb. 21 coordination added (#523)
* Minutes of Feb. 21 coordination added
@graeme-a-stewart
Copy link
Member

graeme-a-stewart left a comment

Hi @GuillermoFidalgo - all looks very good, aside from the fact that the CMS SHERPA school is actually a restricted URL, so you'll need to find something more public if you want to list that one.

Show resolved Hide resolved Schools/_posts/2019-02-01-CMS-SHERPA.md Outdated

GuillermoFidalgo added some commits Mar 6, 2019

@graeme-a-stewart
Copy link
Member

graeme-a-stewart left a comment

Ah, noticed one last small thing to fix...

Show resolved Hide resolved Schools/_posts/2019-02-02-Trans-Siberian-School.md Outdated

graeme-a-stewart added some commits Mar 7, 2019

@GuillermoFidalgo

This comment has been minimized.

Copy link
Contributor Author

GuillermoFidalgo commented Mar 7, 2019

Thanks Graeme!!

Delete school entry that has a problematic URL
Page uses self-redirects to set cookies, but this is deeply incompatibly with the URL link checker, so we need to remove it.
@graeme-a-stewart

This comment has been minimized.

Copy link
Member

graeme-a-stewart commented Mar 7, 2019

OK, last URL failures are all spurious so good to merge

@graeme-a-stewart graeme-a-stewart merged commit d07f69d into HSF:master Mar 7, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.