Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date formatting of day selector #2907

Closed
datarttu opened this issue Aug 22, 2019 · 2 comments
Closed

Fix date formatting of day selector #2907

datarttu opened this issue Aug 22, 2019 · 2 comments

Comments

@datarttu
Copy link

Date format example

Just a small detail I noticed in the Reittiopas UI: the month number should have a trailing . character, according to the Finnish ortography rules. Probably this can be fixed by modifying DateSelect.js. I am not very familiar with the app structure, though.

I also found out that changing the UI language in the top pane does not change the date format. This is problematic since the current format uses Finnish weekday abbreviations. Is there a simple way to add localization to the date formats?

@optionsome
Copy link
Member

We can easily fix the first issue with missing trailing '.'. The other issue is slightly more complicated. We do have localized weekday abbreviations but they do not always update properly when you change the language.

@optionsome optionsome mentioned this issue Sep 10, 2019
@optionsome
Copy link
Member

The fixes for the aforementioned issues are now in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants