New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Campaign - Image Upload Limits #2219

Open
stevejgordon opened this Issue Jan 15, 2018 · 4 comments

Comments

4 participants
@stevejgordon
Member

stevejgordon commented Jan 15, 2018

When logged in as a site admin or organization admin, the user can create new campaigns in allReady.

Currently there is an image upload option but we do not limit the size of the upload or scale the uploaded image. This may lead to unneccesarily large images being uploaded and affecting page load times.

We should do at least one of the following:

  1. Limit the max dimension on the long edge for the image and/or the filesize
  2. Ideally, scale the image or provide a client side image cropper and resizer before uploading the image.

We should also ensure that we only allow image file types to be uploaded. Currently it seems that any file can be chosen and will upload. This could present a security risk!

@stevejgordon

This comment has been minimized.

Member

stevejgordon commented Jan 15, 2018

Reserved for .NET South East codeathon

@Paul-Hadfield

This comment has been minimized.

Collaborator

Paul-Hadfield commented Jan 20, 2018

I'll pick this up after #2228 as code has been created for that issue

Paul-Hadfield added a commit to Paul-Hadfield/allReady that referenced this issue Jan 20, 2018

Introduce builder pattern for HTBox#2283
Another builder pattern, this time ahead of introducing new parameter in HTBox#2219

Paul-Hadfield added a commit to Paul-Hadfield/allReady that referenced this issue Jan 20, 2018

Validating max file size
As requested in HTBox#2219, we are now validating that the max file size is below a configurable value.  This is using same code as HTBox#2228.  Will go back and tidy up tests in future, creating / editing events didn't have tests implemented but can use  create/edit campaign as template
@Paul-Hadfield

This comment has been minimized.

Collaborator

Paul-Hadfield commented Jan 21, 2018

I think this was has been fixed and waiting to be merged into main code base.

@stimms

This comment has been minimized.

Contributor

stimms commented Mar 6, 2018

@stevejgordon or @MisterJames can you confirm that this issue is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment