New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UnitTest builder pattern for AllReady.Areas.Admin.Controllers.EventController #2263

Closed
Paul-Hadfield opened this Issue Jan 20, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@Paul-Hadfield
Collaborator

Paul-Hadfield commented Jan 20, 2018

Whilst working on #2228 adding the image size validator to the constructor caused many of the unit tests to fail building. Implementing the Builder pattern for the constructor of the controller should help stop this being a problem in the future.

@Paul-Hadfield

This comment has been minimized.

Collaborator

Paul-Hadfield commented Jan 20, 2018

I'll work on this one as part of cleaning up after #2228

Paul-Hadfield added a commit to Paul-Hadfield/allReady that referenced this issue Jan 20, 2018

Introduce Builder pattern HTBox#2263
Introduce the builder patter for Event Admin Controller unit tests

MisterJames added a commit that referenced this issue Mar 6, 2018

Merge pull request #2310 from stimms/feature/use_builder_in_test
Adding builder to more easily create subjects in the tests. Fixes #2263

stevejgordon added a commit that referenced this issue Apr 16, 2018

Merge pull request #2282 from Paul-Hadfield/master
Brings in builder pattern for #2263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment