New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings in builder pattern for #2263 #2282

Merged
merged 11 commits into from Apr 16, 2018

Conversation

Projects
None yet
3 participants
@Paul-Hadfield
Collaborator

Paul-Hadfield commented Jan 20, 2018

No description provided.

Paul-Hadfield added some commits Jan 20, 2018

Introduce Builder pattern #2263
Introduce the builder patter for Event Admin Controller unit tests
Introduce builder pattern for #2283
Another builder pattern, this time ahead of introducing new parameter in #2219
Validating max file size
As requested in #2219, we are now validating that the max file size is below a configurable value.  This is using same code as #2228.  Will go back and tidy up tests in future, creating / editing events didn't have tests implemented but can use  create/edit campaign as template
@MisterJames

This comment has been minimized.

Contributor

MisterJames commented Feb 6, 2018

Hi @Paul-Hadfield, there are a few conflicts here on the controller tests, would you be able to resolve?

Paul-Hadfield added some commits Mar 6, 2018

@Paul-Hadfield

This comment has been minimized.

Collaborator

Paul-Hadfield commented Mar 6, 2018

Hi @MisterJames, sorry I missed your comment about the conflicts, I think I've sorted these now (and it's passed build test)

Paul-Hadfield added some commits Mar 7, 2018

@stevejgordon stevejgordon merged commit 8aeecd1 into HTBox:master Apr 16, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment