Skip to content

Commit

Permalink
Fix errors in contributors (#546)
Browse files Browse the repository at this point in the history
* Fix errors in contributors

* Fix tab order issue
  • Loading branch information
tunetheweb authored and rviscomi committed Nov 26, 2019
1 parent ebfdee2 commit 31cf6fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/config/2019.json
Expand Up @@ -226,7 +226,8 @@
"dotjs": {
"name": "Andrew Galloni",
"teams": [
"analysts"
"analysts",
"reviewers"
],
"avatar_url": "https:\/\/avatars3.githubusercontent.com\/u\/2914966?v=4&s=200",
"github": "dotjs",
Expand Down Expand Up @@ -626,6 +627,7 @@
"name": "Martin Splitt",
"bio":"Martin Splitt is a developer advocate on the web ecosystem team at Google where he works on keeping the web discoverable.",
"teams": [
"authors",
"brainstormers"
],
"avatar_url": "https:\/\/avatars2.githubusercontent.com\/u\/370246?v=4&s=200",
Expand Down
4 changes: 2 additions & 2 deletions src/templates/en/2019/contributors.html
Expand Up @@ -309,7 +309,7 @@ <h1 class="title title-lg">

<div class="contributor-grid">
{% for id, contributor in config.contributors.items() %}
<div class="contributor {{ ' '.join(contributor.teams) }}" id="{{ id }}" tabindex="0">
<div class="contributor {{ ' '.join(contributor.teams) }}" id="{{ id }}" tabindex="-1">
<img class="contributor-avatar" src="{{contributor.avatar_url}}" height="100" width="100" alt="{{ contributor.name }} avatar" loading="lazy" />
<div class="contributor-name">{{ contributor.name }}</div>

Expand All @@ -318,7 +318,7 @@ <h1 class="title title-lg">
<a href="https://github.com/{{ contributor.github }}" target="_blank" title="{{ contributor.github }} on GitHub"><img src="/static/images/github.png" alt="GitHub" height="80" width="78" loading="lazy" /></a>
{% endif %}
{% if contributor.twitter %}
<a href="https://twitter.com/{{ contributor.twitter }}" target="_blank" title="{{ contributor.github }} on Twitter"><img src="/static/images/twitter.png" title="Twitter" height="80" width="65" loading="lazy" /></a>
<a href="https://twitter.com/{{ contributor.twitter }}" target="_blank" title="{{ contributor.twitter }} on Twitter"><img src="/static/images/twitter.png" alt="Twitter" height="80" width="65" loading="lazy" /></a>
{% endif %}
{% if contributor.website %}
<a href="{{ contributor.website }}" target="_blank" title="{{ contributor.name }} website"><img src="/static/images/blog.png" alt="website" height="72" width="72" loading="lazy" /></a>
Expand Down

0 comments on commit 31cf6fb

Please sign in to comment.