Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedit completed contents #218

Closed
rviscomi opened this issue Oct 22, 2019 · 28 comments · Fixed by #504
Closed

Copyedit completed contents #218

rviscomi opened this issue Oct 22, 2019 · 28 comments · Fixed by #504
Assignees
Labels
Projects
Milestone

Comments

@rviscomi
Copy link
Member

@rviscomi rviscomi commented Oct 22, 2019

Go through each chapter and "contentful" page to ensure that it fits our "work fun" voice, fix spelling and grammar, and finalize formatting. See the Editors' Wiki for an explicit list of best practices.

Whenever possible, also try to interlink chapters (#253).

@rviscomi rviscomi added the Writing label Oct 22, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Oct 22, 2019
@rviscomi rviscomi added this to TODO in Web Almanac via automation Oct 22, 2019
@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Oct 22, 2019

@ekharvey @Meggin @rachellcostello IIRC you've all expressed interest in helping out with copyediting. If you still have time over the next 3 weeks to review content, it'd be a huge help! 🙏

@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Oct 22, 2019

The following chapters are merged and ready for editing:

3. Markup
5. Third Parties
10. SEO
11. PWA
20. HTTP/2

Markdown files are available at src/content/en/2019.

Most of them still need data viz embedded but that shouldn't block.

@rachellcostello rachellcostello self-assigned this Oct 22, 2019
@rachellcostello

This comment has been minimized.

Copy link
Contributor

@rachellcostello rachellcostello commented Oct 22, 2019

Of course, happy to help with proofreading and editing wherever needed! I can start off with the SEO chapter, but I can tackle some of the others as well so feel free to divide up the remaining chapters and assign me more.

@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Oct 22, 2019

Great thanks @rachellcostello! Yes, go ahead and start with the SEO chapter.

To make sure everyone is following the same guidelines I started a wiki page for us to drop in our editing decisions. As you go through the content and establish new editing rules, add them to the wiki.

@obto

This comment has been minimized.

Copy link
Contributor

@obto obto commented Oct 22, 2019

Currently reviewing and editing the caching, javascript, mobile web and a11y chapters. After those have been merged in, I'd be happy to edit the rest 👍

@rviscomi rviscomi mentioned this issue Oct 24, 2019
@rachellcostello

This comment has been minimized.

Copy link
Contributor

@rachellcostello rachellcostello commented Oct 24, 2019

I've finished reviewing the SEO chapter and will work on Performance next, looks like that has just been merged

@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Oct 29, 2019

@rachellcostello after #249 is merged the Performance chapter should be ready for editing. Just had to rewrite it a bit and add data viz.

@bazzadp

This comment has been minimized.

Copy link
Contributor

@bazzadp bazzadp commented Oct 29, 2019

@rviscomi, @rachellcostello, @obto what do you think of #253 that I've just raised? One to bear in mind as we copyedit the remaining chapters?

P.S. And sorry if that sounds like a dig at your chapter @rachellcostello - it honestly isn't meant like that!

@bazzadp bazzadp mentioned this issue Oct 29, 2019
3 of 3 tasks complete
@rachellcostello

This comment has been minimized.

Copy link
Contributor

@rachellcostello rachellcostello commented Oct 30, 2019

Not at all @bazzadp - I completely agree! I believe that placeholders were left for internal links as we didn't know what the final URLs would be for the other chapters, so it was a good example for you to reference :)

@rachellcostello

This comment has been minimized.

Copy link
Contributor

@rachellcostello rachellcostello commented Oct 30, 2019

I was going to proofread some other chapters while waiting for #249 to be merged, but looks like the list of finished chapters have other editors already assigned currently. I'll keep an eye out for any new chapters in src/content/en, but let me know if there's anything you need help with in the meantime @rviscomi and @obto

@rachellcostello

This comment has been minimized.

Copy link
Contributor

@rachellcostello rachellcostello commented Oct 30, 2019

Oh wait looks like HTTP/2 is ready, I'll take a look at that one too.

@bazzadp

This comment has been minimized.

Copy link
Contributor

@bazzadp bazzadp commented Oct 30, 2019

Be kind - that one’s mine! 😀 Ping me if you’ve any questions.

Can you do me a favour and correct my name in the meta data at the top from my twitter name (tunetheweb) to my GitHub name (bazzadp) since that’s the convention we’re going for?

Also now we know the URL structure as per #253 if you could correct the other chapter links I have to those that would be good.

@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Nov 2, 2019

@obto since you wrote the mweb chapter I'll edit it with a fresh set of eyes :)

@obto

This comment has been minimized.

Copy link
Contributor

@obto obto commented Nov 5, 2019

@rachellcostello Sorry i forgot to edit the list in here to show I've been working on page weight. Already halfway finished and a PR up.

@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Nov 6, 2019

Media and CMS are also ready for editing.

BTW this sheet is kept up to date (and is the source of truth) for the latest status of each chapter. All pending chapters with "Editing" status are fair game. Add your username to the checklist in the first comment to claim it.

Part Chapter Stage
I. Page Content 1. JavaScript Editing
I. Page Content 2. CSS Editing
I. Page Content 3. Markup Done
I. Page Content 4. Media Editing
I. Page Content 5. Third Parties Data Viz
I. Page Content 6. Fonts Editing
II. User Experience 7. Performance Done
II. User Experience 8. Security Editing
II. User Experience 9. Accessibility Done
II. User Experience 10. SEO Data Viz
II. User Experience 11. PWA Data Viz
II. User Experience 12. Mobile Web Done
III. Content Publishing 13. Ecommerce Data Viz
III. Content Publishing 14. CMS Editing
IV. Content Distribution 15. Compression Data Viz
IV. Content Distribution 16. Caching Done
IV. Content Distribution 17. CDN Peer Review
IV. Content Distribution 18. Page Weight Done
IV. Content Distribution 19. Resource Hints Editing
IV. Content Distribution 20. HTTP/2 Done
@bazzadp

This comment has been minimized.

Copy link
Contributor

@bazzadp bazzadp commented Nov 8, 2019

I've added some of the steps I'm doing to the Editor's Wiki.

In part to remind myself, in part for future, and in part in case someone comes a long and offers to help this weekend!

Free free to add to it!

@rviscomi

This comment has been minimized.

Copy link
Member Author

@rviscomi rviscomi commented Nov 11, 2019

@rachellcostello have you had a chance to edit the Media chapter?

@davelab6 davelab6 unpinned this issue Nov 11, 2019
@rviscomi rviscomi pinned this issue Nov 11, 2019
@bazzadp

This comment has been minimized.

Copy link
Contributor

@bazzadp bazzadp commented Nov 11, 2019

@rachellcostello have you had a chance to edit the Media chapter?

Spoke to @rachellcostello and she's travelling so I said I'd take first pass at this, after I fix the typos in #460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.