Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Chapter #231

Merged
merged 14 commits into from Nov 5, 2019
Merged

CSS Chapter #231

merged 14 commits into from Nov 5, 2019

Conversation

argyleink
Copy link
Contributor

fixes #132

placing this here to show we're working on it as well as get early and often feedback.

@argyleink argyleink added the writing Related to wording and content label Oct 24, 2019
src/content/en/2019/css.md Outdated Show resolved Hide resolved
src/content/en/2019/css.md Outdated Show resolved Hide resolved
src/content/en/2019/css.md Outdated Show resolved Hide resolved
src/content/en/2019/css.md Outdated Show resolved Hide resolved
Copy link

@huijing huijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly sentence structure edits. Looking forward to the rest of this :)

Flushing out color section text
@rviscomi rviscomi added this to TODO in Web Almanac 2019 via automation Oct 24, 2019
@rviscomi rviscomi added this to the Content written milestone Oct 24, 2019
@rviscomi rviscomi moved this from TODO to In Progress in Web Almanac 2019 Oct 24, 2019
Added a note about Hex
Added unit section written content
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to reading the rest. Good work on it so far!

Percentage of types used
<bar chart of 02_06>

### Color Selection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People might also enjoy reading about the least popular named colors (papayawhip, etc)


### Color Types

Hex is the most popular way to describe color by far (with 93% usage), followed by RGB and then HSL. Interestingly, developers are taking full advantage of the alpha-transparency argument when it comes to these color types. HSLA and RGBA are far more popular than HSL and RGB, with almost double the usage! Even though the alpha-transparency was added later to the web spec, HSLA and RGBA are supported [as far back as IE9](https://caniuse.com/#feat=css3-colors), so you can go ahead and use them, too!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be specific about what the "93%" refers to. For example "93% of desktop websites include a stylesheet that uses this color type."

Hex is the most popular way to describe color by far (with 93% usage), followed by RGB and then HSL. Interestingly, developers are taking full advantage of the alpha-transparency argument when it comes to these color types. HSLA and RGBA are far more popular than HSL and RGB, with almost double the usage! Even though the alpha-transparency was added later to the web spec, HSLA and RGBA are supported [as far back as IE9](https://caniuse.com/#feat=css3-colors), so you can go ahead and use them, too!

Percentage of types used
<bar chart of 02_06>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI here's how it'll look:

image

There are [148 named CSS colors](https://www.w3.org/TR/css-color-4/#named-colors), not including the special values `transparent` and `currentcolor`. You can use these by their string name for more readible styling. The most popular named colors are black and white, unsurprisingly, followed by red and blue.

Top named colors
<pie chart of 02_06b>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is one of my favorite charts :)

image

@rviscomi rviscomi added the ASAP This issue is blocking progress label Oct 29, 2019
@rviscomi
Copy link
Member

Thanks for working on this @argyleink @una! Hoping to get it merged asap in prep for launch next week. Besides finding the time are you currently blocked on anything I can help with?

@argyleink
Copy link
Contributor Author

nothin's blockin me but all my other responsibilities! I'm pushing each one forward every day, I'll spend another couple hours on this tomorrow. Thanks for patiently pinging!

@argyleink
Copy link
Contributor Author

@huijing @meyerweb & @rviscomi,

ready for a hardcore review!! i expect there to be many typos, grammar issues, uses of the "i" instead of "we", etc. help me harden this, remove any language that doesnt translate, etc. thanks for helping!

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great. I have some copyediting suggestions that I'll put in a follow-up PR, in the interest of getting this merged and ready for launch. Thanks everyone!

@meyerweb @huijing if you have any peer review feedback you can always file a new issue or PR.

@rviscomi rviscomi merged commit 7cbe549 into HTTPArchive:master Nov 5, 2019
Web Almanac 2019 automation moved this from In Progress to Done Nov 5, 2019
@rviscomi rviscomi removed the ASAP This issue is blocking progress label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Write content: Chapter 2. CSS
4 participants