Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate JavaScript chapter to Spanish #536

Merged
merged 19 commits into from Nov 26, 2019
Merged

Conversation

c-torres
Copy link
Contributor

Progress on #498

@c-torres c-torres added the translation world wide web label Nov 24, 2019
@c-torres c-torres changed the title Translatie JavaScript chapter to Spanish Translate JavaScript chapter to Spanish Nov 24, 2019
@rviscomi rviscomi added this to TODO in Web Almanac 2019 via automation Nov 24, 2019
@rviscomi rviscomi added this to the Après Ski milestone Nov 24, 2019
@rviscomi
Copy link
Member

I'll defer to @taytus and @JMPerez for the content review. Feel free to merge when approved.

Copy link
Contributor

@JMPerez JMPerez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting fixes

c-torres and others added 2 commits November 25, 2019 15:40
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
c-torres and others added 16 commits November 25, 2019 15:40
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
Co-Authored-By: José M. Pérez <JMPerez@users.noreply.github.com>
@rviscomi
Copy link
Member

@c-torres can you also run npm run generate to create the HTML version of the chapter?

@tunetheweb
Copy link
Member

@c-torres can you also run npm run generate to create the HTML version of the chapter?

Don't think we can do this as don't have all the HTML templates translated for Spanish yet. So shall we just merge as is?

@rviscomi
Copy link
Member

We can either run the script now as part of this PR, or the next person to run it will pick up these changes and it'll be included in their PR. I think it's best to keep all relevant artifacts in the same PR.

@rviscomi
Copy link
Member

Disregard, @bazzadp was right. :)

@rviscomi rviscomi merged commit 816c0d2 into master Nov 26, 2019
Web Almanac 2019 automation moved this from TODO to Done Nov 26, 2019
@rviscomi rviscomi deleted the c-torres/javascript branch November 26, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants