Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Conversation

@giancarloaf
Copy link
Contributor

@giancarloaf giancarloaf commented May 25, 2022

Fixes #52

Validation

@giancarloaf giancarloaf added this to the M1: Increasing capacity milestone May 25, 2022
@giancarloaf giancarloaf added the bug Something isn't working label May 25, 2022
@rviscomi rviscomi marked this pull request as ready for review May 25, 2022 15:40
@rviscomi
Copy link
Member

rviscomi commented May 26, 2022

Ran this query to find a few test cases with known big ints:

WITH req AS (
  SELECT
    pageid,
    LENGTH(REGEXP_EXTRACT(resp_cache_control, r'(?i)max-age\s*=\s*(\d+)')) AS cc_digits
  FROM
    `httparchive.summary_requests.2022_04_01_mobile`
), pages AS (
  SELECT
    pageid,
    wptid
  FROM
    `httparchive.summary_pages.2022_04_01_mobile`
)

SELECT DISTINCT
  wptid,
  cc_digits
FROM
  req
JOIN
  pages
USING
  (pageid)
WHERE
  cc_digits > 20
ORDER BY
  cc_digits DESC
LIMIT
  5

Ran android-Apr_1_2022/220410_MxAZ_NEMA.har.gz through the pipeline synced with this branch, and it completed successfully.

@giancarloaf giancarloaf merged commit 0e63db7 into main May 26, 2022
@giancarloaf giancarloaf deleted the feat/clamp-all-integers branch May 26, 2022 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summary pipeline: TypeError: Integer exceeds 64-bit range (while running WriteRequestsToBigQuery...)

4 participants