New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements water wave #22

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
2 participants
@captn3m0

captn3m0 commented Apr 23, 2017

I don't expect this to be merged, just creating this PR in case someone is interested in using curves instead of bars for visualization.

Visualization demo is at https://www.youtube.com/watch?v=_vWe_AHAJCk

GIF:

output

Would it be worth it to consider "configurable renderers" so that bars|curves could be picked?

@HaCk3Dq

This comment has been minimized.

Show comment
Hide comment
@HaCk3Dq

HaCk3Dq Apr 24, 2017

Owner

Wow, that's neat, dude

What concerns different renderers: i think they should be implemented in a separate way, some sort of a plugins. Need to architecture them right, to make it more customisable

Owner

HaCk3Dq commented Apr 24, 2017

Wow, that's neat, dude

What concerns different renderers: i think they should be implemented in a separate way, some sort of a plugins. Need to architecture them right, to make it more customisable

@captn3m0

This comment has been minimized.

Show comment
Hide comment
@captn3m0

captn3m0 Apr 24, 2017

Would creating separate render_{method} functions be good enough, where method is decided by the config?

captn3m0 commented Apr 24, 2017

Would creating separate render_{method} functions be good enough, where method is decided by the config?

@HaCk3Dq

This comment has been minimized.

Show comment
Hide comment
@HaCk3Dq

HaCk3Dq Apr 25, 2017

Owner

Seems right

Owner

HaCk3Dq commented Apr 25, 2017

Seems right

@captn3m0

This comment has been minimized.

Show comment
Hide comment
@captn3m0

captn3m0 Apr 30, 2017

@HaCk3Dq Made the render method configurable via the config and squashed all my commits

captn3m0 commented Apr 30, 2017

@HaCk3Dq Made the render method configurable via the config and squashed all my commits

Implements curves render method
- The curve is filled the same way as bars
- 2 config options have been added for
  bars.count (number of bars) and render.method

@HaCk3Dq HaCk3Dq merged commit 8599a00 into HaCk3Dq:master May 2, 2017

@HaCk3Dq

This comment has been minimized.

Show comment
Hide comment
@HaCk3Dq

HaCk3Dq May 2, 2017

Owner

Ty a lot

Owner

HaCk3Dq commented May 2, 2017

Ty a lot

@captn3m0 captn3m0 deleted the captn3m0:water branch May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment