New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browsing/monitoring non-git directories #71

Merged
merged 1 commit into from Jan 5, 2015

Conversation

Projects
None yet
3 participants
@shana
Contributor

shana commented Dec 11, 2014

Update view model when selecting an empty/non-git directory so that UI
refreshes correctly.

Make sure the observable for the git directory creation event gets
disposed after getting one event, so that FileSystemWatchers listening
for creation events don't accumulate if the directory is created more
than once.

Fix browsing/monitoring non-git directories
Update view model when selecting an empty/non-git directory so that UI
refreshes correctly.

Make sure the observable for the git directory creation event gets
disposed after getting one event, so that FileSystemWatchers listening
for creation events don't accumulate if the directory is created more
than once.
RepositoryPath = repositoryWorkingPath;
string gitPath = ModelExtensions.GetGitRepositoryPath(repositoryWorkingPath);

This comment has been minimized.

@Therzok

Therzok Dec 11, 2014

Collaborator

repositoryWorkingPath.GetGitRepositoryPath().

@Therzok

Therzok Dec 11, 2014

Collaborator

repositoryWorkingPath.GetGitRepositoryPath().

This comment has been minimized.

@shana

shana Dec 12, 2014

Contributor

GetGitRepositoryPath is not actually an extension method for strings (class name notwithstanding)

@shana

shana Dec 12, 2014

Contributor

GetGitRepositoryPath is not actually an extension method for strings (class name notwithstanding)

This comment has been minimized.

@Therzok

Therzok Dec 12, 2014

Collaborator

That's what I get for reviewing without checking the code. 😭 Sorry!

@Therzok

Therzok Dec 12, 2014

Collaborator

That's what I get for reviewing without checking the code. 😭 Sorry!

Haacked added a commit that referenced this pull request Jan 5, 2015

Merge pull request #71 from andreiagaita/monitor-empty-dirs
Fix browsing/monitoring non-git directories

@Haacked Haacked merged commit 355c35b into Haacked:master Jan 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment