Make encouragements configurable #8

Merged
merged 3 commits into from Jun 9, 2016

Projects

None yet

2 participants

@armstnp
Contributor
armstnp commented Jun 9, 2016

Addresses #3: Adds atom package configuration, allowing you to enter a comma-separated list of encouragements to pull from (as well as providing @Haacked 's cheery set of encouragements by default!)

I was unable to determine a reasonable way to update the specification to determine that the encouragements are drawn from the configuration. It doesn't necessarily help that atom provides a lot of functionality from the global context. Any thoughts or recommendations there?

@Haacked
Owner
Haacked commented Jun 9, 2016

Thanks!

I was unable to determine a reasonable way to update the specification to determine that the encouragements are drawn from the configuration. It doesn't necessarily help that atom provides a lot of functionality from the global context. Any thoughts or recommendations there?

Yeah, I'm not sure how to do that. @lee-dohm, any thoughts? Also, is there a way to provide a custom UI for settings?

@Haacked
Owner
Haacked commented Jun 9, 2016

@Haacked Haacked merged commit 5c7a5ca into Haacked:master Jun 9, 2016

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment