New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter to confirm character choice in IME creates new checklist line #8326

Closed
citrusella opened this Issue Dec 28, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@citrusella
Copy link

citrusella commented Dec 28, 2016

Description

I was asked to create a new issue here after a discussion in the Report a Bug guild about this; I think the most succinct way I can describe it is a modified version of the long post I created in the guild explaining the issue after I tested what I thought user chan_gami was talking about:

(I'll use Microsoft's IME as it works on Windows 7 as an example, since it's what I have at my disposal that I know how to use, but most IMEs work in similar ways. The images below have tooltips further explaining them when they are hovered over.) When you use an IME (a typing method that allows you to use one input format (i.e. a latin keyboard) to type in a different one (i.e. a syllabic/logographic language)) to enter Japanese, you type in kana (hiragana, usually) and it shows up underlined.

えいが with a black squiggly line under it

Then you hit space to use the IME's dictionary to select what kanji you want based on the hiragana/words you typed in.

映画 with a dropdown under it displaying various kanji choices; the displayed term, 映画, is highlighted as the selection

Enter confirms your choice and sort of "locks in" that character sequence, I guess (you're not editing the kana in a way that you can select kanji for it anymore and the line under the characters disappears, allowing you to start the process over again if you're not finished).

を has a squiggly line under it but 映画 is no longer underlined

In checklist editing (but not elsewhere that I can find), hitting enter to confirm the IME choice is also being interpreted as the "enter" that creates a new checklist line, which isn't ideal if you were just partway through the message since you have to return to the previous line to write more. Here's an example if you're only writing part of a line at a time (I'll go word by word in the examples below (though an IME can technically handle multiple words at a time) to show how it should look vs. how it'd be interpreted for checklists if you didn't return to the original checklist item.)

Here is the sentence in full, along with a table splitting it into chunks based on how I typed it for use in this example:

Full sentence: メアリーさん、映画を見に行きましょう。

Romaji (from QWERTY typing) meari-san, eiga wo mi ni ikimashou.
Kana (pre-space-press) めありーさん、 えいが いきましょう。
Final characters chosen メアリーさん、 映画 行きましょう。

Below is how the sentence would look if the enter to confirm the character choices (separated like above) also created a new line:

メアリーさん、
映画



行きましょう。

That is to say, if you didn't return to the first checklist item, a new one would be created for each thing you typed and pressed enter to confirm. I'm not sure I've seen that as a usual behavior in most places I've used an IME (granted, most places I've used an IME are language-learning sites). The usual behavior I've seen is that the enter for the IME character choice is ignored (somehow) and only non-IME-choice-confirming enter presses result in the action pressing enter is supposed to achieve.

So the behavior one might expect to see in terms of how IME choice usually functions is that the IME kana-to-kanji-conversion enter press would do nothing and only a typical enter press (i.e. outside of the IME/with intent to create a new line, the way it works in English) would create a new checklist item. But instead, with checklist items on Habitica, currently IME-confirm presses and "normal" presses do it. I think this probably happens across various systems and browsers (and IMEs if they function similarly, even if they're non-Microsoft or non-Japanese, i.e. a Google Chinese/pinyin IME), even though I've only tested on Windows 7 with Microsoft IME in Firefox. (For instance, chan_gami reported it on Mac OS Sierra with Chrome, Firefox, and Safari via Google's Japanese IME.)

...It was very confusing to write this (or, well, to modify it to post here), so if something needs to be clarified, please let me know.

@citrusella citrusella changed the title Pressing enter to confirm character choice in IME Pressing enter to confirm character choice in IME creates new checklist line Dec 28, 2016

@changami

This comment has been minimized.

Copy link
Contributor

changami commented Dec 28, 2016

@citrusella Thanks for the great and detailed explanation!

I recorded this behavior.
habitica_bug_report

And, can I investigate if possible?

@Alys

This comment has been minimized.

Copy link
Contributor

Alys commented Dec 28, 2016

@changami Great video - thank you! That really helps.

Yes, you'd be most welcome to look into this! Ask here if you have any questions or run into any trouble. This is a usability issue so it would be good for it to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment