Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Plans task approval list needs information about task types, better formatting #8677

Closed
Alys opened this issue Apr 17, 2017 · 4 comments

Comments

@Alys
Copy link
Contributor

commented Apr 17, 2017

When a member of a group plan completes a task that requires approval, the group leader sees the approvals as shown in the screenshot below.

  1. It's not possible to tell whether the tasks are Habits, Dailies, To-Dos, or Rewards. In the case below, for the first two tasks, one is a Habit and one a Daily. There needs to be an indication of task type.
  2. For Habits, it's also not possible to tell if the member clicked the plus or minus button, which is important to know for correctly approving it. It should state whether plus or minus was clicked.
  3. There should also be more distinction for the name of the task. At the moment, it blends in with the user information (the task names for the first two tasks here are "clean your room").
  4. Markdown and emoji in the task title should be rendered.

image

Note that there is currently an issue with negative clicks on group plans Habits being treated as positive clicks (#8676). It's possible that point 2 above can't be fixed until that issue is fixed (e.g., if the approval screen currently can't tell if plus or minus was clicked).

@jsjoeio

This comment has been minimized.

Copy link
Contributor

commented May 21, 2017

Hi! May I start working on this now?

@Alys

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2017

@jjprevite Yes, thank you! Comment here if you have questions about it.

@jsjoeio

This comment has been minimized.

Copy link
Contributor

commented May 24, 2017

@Alys I'm trying to create a Group Plan in my test environment. How do I bypass the Credit Card/Amazon Pay on the Upgrade to group plans page(http://localhost:3000/#/options/groups/group-plans)?

My thought process for solving this issue is:

  1. create a Group Plan
  2. invite other users to Group
  3. on their accounts, have them add tasks to Group Task List
  4. login to Group Plan Leader and view Group Plan task approval list
  5. inspect code on Chrome to locate source code and see how everything interacts
  6. figure out the best way indicate a task type so that a Group Leader knows which is which
  7. fix other issues

P.S. - should I be asking you this question or would you prefer I start in the guild and then ask? (Sorry, this is my first time contributing so I'm still learning the ropes!)

@Alys

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2017

@jjprevite I believe it's possible to create a test Stripe account, which would give you keys to put into config.json to replace the placeholder text below. You could then use fake credit card details to make purchases. Details should be at https://stripe.com/docs/testing

"STRIPE_API_KEY":"aaaabbbbccccddddeeeeffff00001111",
"STRIPE_PUB_KEY":"22223333444455556666777788889999",

You can also create a guild or party normally and then upgrade it to have a group plan by using a mongodb update command to change the group's purchased object to this:

"purchased" : {
	"plan" : {
		"customerId" : "group-unlimited",
		"dateCreated" : ISODate("2017-01-01T01:01:01.001Z"),
		"dateTerminated" : null,
		"dateUpdated" : ISODate("2017-01-01T01:01:01.001Z"),
		"owner" : "your test account User ID goes here",
		"paymentMethod" : "Group Unlimited",
		"planId" : "group_monthly",
		"subscriptionId" : "",
		"consecutive" : {
			"trinkets" : 0,
			"gemCapExtra" : 0,
			"offset" : 0,
			"count" : 0
		},
		"mysteryItems" : [ ],
		"gemsBought" : 0,
		"extraMonths" : 0,
		"quantity" : 6
	}
}
This was referenced Jun 2, 2017

SabreCat added a commit that referenced this issue Jul 1, 2017

Group Approvals Formatting - Fix #8677 (#8784)
* Add task indication to Group Plans Tasks Awaiting Approval page

* Render markdown tasks on Group Plans Tasks Awaiting Approval page

* Fix panel code- fixes formatting issue of Approve button on Group Plans Tasks Awaiting Approval page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.