Veteran Pet ladder award for users affected by username changes #10765

SabreCat · 2018-10-17T19:47:35Z

Adds a new veteran pet to the awards ladder, the Veteran Fox.
Adds a migration to award the next Veteran Pet on the ladder to users who have already verified their usernames.
Awards the next Veteran Pet on the ladder to users who verify their usernames if not already verified.
Awards the first Veteran Pet on the ladder to newly registering users.

The migration uses the same batching template we've relied on in the past, but updated to use the Mongoose model instead of monk. It deserves extra scrutiny for this first such use case.

paglias

LGTM, left just one comment

paglias · 2018-10-18T16:06:50Z

migrations/users/20181019_veteran_pet_ladder.js

+
+  if (count % progressCount === 0) console.warn(`${count} ${user._id}`);
+
+  return User.update({_id: user._id}, {$set: set}).exec();


Not super important but here you should be able to use 'user.update()' directly as we have an User instance

feat(usernames): Veteran Pet ladder award for affected users

044fe17

SabreCat added the status: pr: ready for review label Oct 17, 2018

SabreCat requested a review from paglias October 18, 2018 14:58

paglias reviewed Oct 18, 2018

View reviewed changes

feat(content): Vet Pet Bailey etc.

d1aa668

SabreCat changed the base branch from develop to release October 23, 2018 22:15

Merge branch 'release' into sabrecat/veteran-verified

136e747

SabreCat merged commit 2fc1f46 into release Oct 23, 2018

SabreCat deleted the sabrecat/veteran-verified branch October 23, 2018 22:38

Provide feedback


		if (count % progressCount === 0) console.warn(`${count} ${user._id}`);

		return User.update({_id: user._id}, {$set: set}).exec();