Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env vars more palatable for containerization #10895

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@SabreCat
Copy link
Member

commented Dec 5, 2018

Changes

  • Turns all environment variables that were in nested JSON objects and/or used keys including : into pure alphanumeric + underscores.
  • Removes a few unused environment variables.
  • Organizes config.json.example with an alphabetic sort to make it easier to find extant environment variables.

These tweaks should make it more feasible to deploy Habitica on a variety of containerization services, some of which (e.g. Kubernetes) do not support our current style of environment variables.

@SabreCat SabreCat requested a review from paglias Dec 5, 2018

@paglias
Copy link
Contributor

left a comment

LGTM! Much cleaner than before :)

@SabreCat SabreCat merged commit f42e22b into develop Dec 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@SabreCat SabreCat deleted the sabrecat/kubernetes branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.