Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): #5865 API should return flagged messages in chat only to mods #6065

Merged
merged 1 commit into from Nov 4, 2015

Conversation

Projects
None yet
2 participants
@srrvnn
Copy link

srrvnn commented Oct 19, 2015

filtered groups.chat if user.contributor.admin is false in api request for groups, and api request for group chats.

@crookedneighbor

This comment has been minimized.

Copy link
Collaborator

crookedneighbor commented Oct 19, 2015

You changed the threshold for number of flags to block chats from 2 to 3. Was that intentional? Why?

@srrvnn

This comment has been minimized.

Copy link
Author

srrvnn commented Oct 19, 2015

issue #5865 is described as "Chat messages with more than 2 flags should be returned by the API only if they are requested by a moderator." by @paglias. so, i looked for flagCount < 3.

@crookedneighbor

This comment has been minimized.

Copy link
Collaborator

crookedneighbor commented Oct 19, 2015

Got it. It should still be changed back to 2.

@srrvnn srrvnn force-pushed the srrvnn:develop branch from bb67612 to df7fd2e Oct 20, 2015

@srrvnn

This comment has been minimized.

Copy link
Author

srrvnn commented Oct 20, 2015

updated.

@crookedneighbor crookedneighbor added this to the After API Test Migration milestone Oct 20, 2015

@crookedneighbor

This comment has been minimized.

Copy link
Collaborator

crookedneighbor commented Oct 20, 2015

This reasonable to me, but currently it's blocked by a new API test infrastructure we're building. As soon that is merged in, we can add tests for this behavior and merge this in.

@crookedneighbor

This comment has been minimized.

Copy link
Collaborator

crookedneighbor commented Oct 23, 2015

The PR is merged in. Let me know if you need help writing tests.

@srrvnn

This comment has been minimized.

Copy link
Author

srrvnn commented Oct 29, 2015

I'll give it a shot over the weekend.

@crookedneighbor crookedneighbor merged commit df7fd2e into HabitRPG:develop Nov 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@crookedneighbor

This comment has been minimized.

Copy link
Collaborator

crookedneighbor commented Nov 4, 2015

This will count towards a contributor tier! What's your User ID? You can find it in Settings > API. Be sure to only copy the User ID and not your API Token.

@srrvnn

This comment has been minimized.

Copy link
Author

srrvnn commented Nov 5, 2015

that's my user id: 26b44255-6afa-483b-9801-fea6521b485a. yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.