New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change user quest.progress.collect to quest.progress.collectedItems #7612

Merged
merged 16 commits into from Jun 6, 2016

Conversation

Projects
None yet
2 participants
@Alys
Contributor

Alys commented Jun 5, 2016

@Alys Alys changed the title from change user quest.progress.collect to quest.progress.collectedItems -… to change user quest.progress.collect to quest.progress.collectedItems Jun 5, 2016

@@ -117,7 +117,10 @@ function _cleanQuestProgress (merge) {
progress: {
up: 0,
down: 0,
collect: 0,
collect: {type: Schema.Types.Mixed, default: () => {

This comment has been minimized.

@crookedneighbor

crookedneighbor Jun 6, 2016

Collaborator

This is wrong. Leaving a note to elaborate in a minute.

This comment has been minimized.

@crookedneighbor

crookedneighbor Jun 6, 2016

Collaborator

This should be changed to:

collect: {},
collectedItems: 0,

This comment has been minimized.

@Alys

Alys Jun 6, 2016

Contributor

Thanks! Fixed.

@crookedneighbor crookedneighbor merged commit 0a10b2b into HabitRPG:develop Jun 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Alys Alys deleted the Alys:quest-collect-fix branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment