Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow quest progress from attack skills BEFORE quest starts #244

Merged
merged 0 commits into from Jul 16, 2014

Conversation

Projects
None yet
2 participants
@Alys
Copy link
Contributor

commented Jul 3, 2014

Currently, if you do Brutal Smash or Burst of Flames BEFORE you start a quest, they do NOT damage the quest boss if you start the quest later in the day (this is the opposite of how tasks work). This also means that if you are not on a boss or collection quest, then those skills can't damage a World Boss. I think this is counterintuitive and I think users are expecting those skills to act on Drag'on even when they are not on a quest.

This change causes damage from the skills to be treated just like damage from tasks - it's applied to quests started later that day and to Drag'on.

THIS HAS NOT BEEN TESTED. Sorry. :( I have broken my VM temporarily.

Alys added a commit to Alys/tools-for-habitrpg that referenced this pull request Jul 4, 2014

@paglias paglias merged commit 9f0e660 into HabitRPG:develop Jul 16, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.