Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos for TAO and US Ignite to results page #85

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
2 participants
@noahbrenner
Copy link
Collaborator

commented May 22, 2019

M-Lab was already shown, but the others were missing on this page.

The implementation of this patch includes the following:

  • Create a new partial for showing partner logos.
  • Use the new partial on the home page as well as the results page.
  • Explicitly define alt attributes for each image.
  • Display each logo at the same size (specifically, the same width).

I also did a little cleanup on indentation and whitespace use in home.scss and responsive.scss. That was the first commit from this PR, so just look at the second commit for the functional changes.

Closes #69

noahbrenner added some commits May 22, 2019

Add logos for TAO and US Ignite to results page
M-Lab was already shown, but the others were missing on this page.

The implementation of this patch includes the following:

* Create a new partial for showing partner logos.
* Use the new partial on the home page as well as the results page.
* Explicitly define alt attributes for each image.
* Display each logo at the same size (specifically, the same width).

@ryanrolds ryanrolds merged commit 88aba83 into Hack4Eugene:master May 23, 2019

@noahbrenner noahbrenner deleted the noahbrenner:logos branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.