New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sending process to a background thread. Closes issue #5 #6

Merged
merged 4 commits into from Feb 18, 2018

Conversation

2 participants
@AparaV
Copy link
Member

AparaV commented May 12, 2017

Changes

  • Created a background worker with a thread and delegated sending SMS to the worker.
  • Created a new sending view to which the user is redirected to. This view makes AJAX calls every 2 seconds to check for completion of thread. Upon completion, user is redirected to successfully_sent view.
  • Updated README.md to warn users of the potential to be blacklisted by phone carriers. Other minor edits to setup instructions.

Files added

  • mercurysms/templates/sending.html
  • mercurysms/worker.py

Files modified

  • .gitignore
  • README.md
  • mercurysms/templates/base.html
  • mercurysms/urls.py
  • mercurysms/views.py

@AparaV AparaV requested a review from casassg May 12, 2017

@AparaV

This comment has been minimized.

Copy link
Member Author

AparaV commented Jan 3, 2018

Bump @casassg

@casassg
Copy link
Member

casassg left a comment

let's try it 😄

@@ -65,7 +75,7 @@ A list is a column in the mentioned Google Sheets. It is identified by each firs
- Open root route. Ex: http://localhost:8000
- Login with user (you can login with the super user you created in your first steps)
- Send messages right away. Let's SPAM those users :D
- Send messages right away.

This comment has been minimized.

@casassg
@@ -5,6 +5,7 @@
<meta charset="UTF-8">
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/bootstrap/3.2.0/css/bootstrap.min.css">
<script src="https://code.jquery.com/jquery-3.1.1.slim.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>

This comment has been minimized.

@casassg

casassg Feb 18, 2018

Member

why this? there's already a jquery (line above)

This comment has been minimized.

@AparaV

AparaV Feb 18, 2018

Author Member

It said jquery-slim and I wasn't sure if they were the same thing 🤷‍♂️

@casassg casassg merged commit f848363 into HackCU:master Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment