Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TestCase classes for testing. #4

Merged
merged 1 commit into from Jul 11, 2019

Conversation

2 participants
@theomessin
Copy link
Member

commented Jul 11, 2019

This change is Reviewable

@theomessin theomessin requested a review from kkom Jul 11, 2019

@kkom

kkom approved these changes Jul 11, 2019

Copy link

left a comment

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @theomessin)


tests/test_client.py, line 20 at r1 (raw file):

    def setUp(self):
        # Patch Google Cloud libraries.
        # https://docs.python.org/3/library/unittest.mock.html#patch-methods-start-and-stop

i think that's not necessary

we just need to learn as a company how those things work

@kkom

kkom approved these changes Jul 11, 2019

Copy link

left a comment

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @theomessin)


tests/test_client.py, line 87 at r1 (raw file):

    def setUp(self):
        # Patch Google Cloud libraries.
        # https://docs.python.org/3/library/unittest.mock.html#patch-methods-start-and-stop

can delete here too

@theomessin theomessin force-pushed the use_testing_classes branch from 33f32fd to ab39990 Jul 11, 2019

@theomessin theomessin requested a review from kkom Jul 11, 2019

@theomessin
Copy link
Member Author

left a comment

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @kkom)


tests/test_client.py, line 20 at r1 (raw file):

Previously, kkom (Konrad Komorowski) wrote…

i think that's not necessary

we just need to learn as a company how those things work

Done.


tests/test_client.py, line 87 at r1 (raw file):

Previously, kkom (Konrad Komorowski) wrote…

can delete here too

Done.

@theomessin theomessin merged commit 110ff52 into master Jul 11, 2019

1 check was pending

code-review/reviewable 1 file, 2 discussions left (kkom)
Details

@theomessin theomessin deleted the use_testing_classes branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.