Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket naming template functionality. #7

Merged
merged 1 commit into from Jul 11, 2019

Conversation

2 participants
@theomessin
Copy link
Member

commented Jul 11, 2019

This change is Reviewable

@theomessin theomessin requested a review from kkom Jul 11, 2019

@kkom

kkom approved these changes Jul 11, 2019

Copy link

left a comment

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @theomessin)


shush/client.py, line 28 at r1 (raw file):

    @property
    def bucket_name(self) -> str:
        variables = {"location_id": self.bucket_location, "project_id": self.project_id}

location_id / bucket_location - can you pick one?


shush/client.py, line 42 at r1 (raw file):

        keyring_location: str,
        credentials: Optional[Credentials] = None,
        bucket_naming: str = "{location_id}-shush-secrets-{project_id}",

i think bucket_name_template is better

@theomessin theomessin force-pushed the fix-bucket-naming branch from f2db4a0 to 896a930 Jul 11, 2019

@theomessin theomessin requested a review from kkom Jul 11, 2019

@theomessin
Copy link
Member Author

left a comment

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @kkom)


shush/client.py, line 28 at r1 (raw file):

Previously, kkom (Konrad Komorowski) wrote…

location_id / bucket_location - can you pick one?

Done.


shush/client.py, line 42 at r1 (raw file):

Previously, kkom (Konrad Komorowski) wrote…

i think bucket_name_template is better

Done.

@theomessin theomessin force-pushed the fix-bucket-naming branch from 896a930 to ef25b3f Jul 11, 2019

@kkom

kkom approved these changes Jul 11, 2019

Copy link

left a comment

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kkom kkom merged commit dd0b9a3 into master Jul 11, 2019

1 check passed

code-review/reviewable 2 files reviewed
Details

@kkom kkom deleted the fix-bucket-naming branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.