Skip to content
This repository has been archived by the owner. It is now read-only.

Add htmlproofer to test the site integrity #18

Open
wants to merge 9 commits into
base: master
from

Conversation

@jamietanna
Copy link
Member

commented Dec 6, 2016

In order to test the site actually works correctly, and that the
content is well formed, opposed to that it just builds in Jekyll, we
can run htmlproofer, which will test images, links, and other details.

This will give a better early warning system, and will make it possible
to fix issues on a PR (via Travis) opposed to at a later point.

Additionally, this PR will fix the associated errors that have been found by htmlproofer

jamietanna added 7 commits Dec 6, 2016
Add htmlproofer to test the site integrity
In order to test the site actually works correctly, and that the
content is well formed, opposed to that it just builds in Jekyll, we
can run `htmlproofer`, which will test images, links, and other details.

This will give a better early warning system, and will make it possible
to fix issues on a PR (via Travis) opposed to at a later point.
Remove unnecessary `baseurl`
As we're running on the root URL, we don't need any `baseurl`, as it
will then give us incorrect URLs, such as
<http://www.hacksocnotts.github.io//2013/10/27/hackedio.html>
Remove .github.io from URLs
Since we're using the HackSocNotts.co.uk domain, there's no point
having URLs point to Github pages, as they redirect to the domain,
anyway.
Fix relative resource references
Because we weren't correctly referencing the `siteurl`, and after
updating the `baseurl` in 410b3b3, resources would not correctly
resolve, as they would be deemed as relative links.

Additionally, remove any references to `baseurl`, as it's not necessary
with the setup.
Fix incorrectly linked URLs
A number of URLs don't correctly have their protocol set up, so they
point to an internal link instead of the correct site.
Only check against 4xx errors
If a site we're linking to has some downtime, i.e. for a database
connection issue, then that shouldn't stop Hacksoc's site from
deploying. We only want to block our site from being marked as build if
we're i.e. getting a NOT_FOUND or FORBIDDEN request because we've done
something wrong.

@jamietanna jamietanna force-pushed the jamietanna:feature/htmlproofer branch from bcde009 to ea039db Dec 6, 2016

jamietanna added 2 commits Dec 6, 2016
Use Archive.org for broken links
For links that have since gone, let's use the amazing Wayback Machine
from Archive.org to link to old sites.

@jamietanna jamietanna force-pushed the jamietanna:feature/htmlproofer branch from ea039db to 21e382b Dec 6, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.