Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding showPreviousMonths property #1007

Closed
wants to merge 5 commits into from
Closed

Conversation

gyugyu
Copy link

@gyugyu gyugyu commented Aug 31, 2017

This pull request adds showPreviousMonths property to show previous months when monthsShown is configured.

@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #1007 into master will increase coverage by 6.96%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   78.77%   85.73%   +6.96%     
==========================================
  Files          13       12       -1     
  Lines         716      638      -78     
  Branches      141      129      -12     
==========================================
- Hits          564      547      -17     
+ Misses         61        6      -55     
+ Partials       91       85       -6
Impacted Files Coverage Δ
src/calendar.jsx 87.85% <100%> (+2.25%) ⬆️
src/time.jsx
src/datepicker.jsx 92.09% <0%> (+2.14%) ⬆️
src/date_utils.js 100% <0%> (+20.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1957c31...55aaa63. Read the comment docs.

@kblodget
Copy link

Can this functionality be added to the master branch?

@martijnrusschen martijnrusschen added this to To Do in Pull requests Dec 16, 2017
@martijnrusschen
Copy link
Member

Got some merge conflicts, but should be good to go when resolved.

@martijnrusschen martijnrusschen moved this from To Do to Waiting on merge conflict in Pull requests Dec 16, 2017
@kblodget
Copy link

kblodget commented Jan 2, 2018

Is there any way this may be added soon. This would be a great help to the project I am working on. I am willing to help out to get this feature added.

@martijnrusschen
Copy link
Member

@kblodget We're waiting on resolving the merge conflicts.

@martijnrusschen
Copy link
Member

Closing due inactivity.

Pull requests automation moved this from Waiting on merge conflict to Done Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Pull requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants