Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling safari input bug #1845

Open
wants to merge 4 commits into
base: master
from

Conversation

@pmendozav
Copy link

commented Aug 8, 2019

Input time for Safari browser crashes because input tag with type = "time" is not compatible with it browser. This branch check if browser is Safari and replace input tag with the react-simple-timefield.

Pavel Mendoza
@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #1845 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
+ Coverage   90.45%   90.49%   +0.03%     
==========================================
  Files          17       17              
  Lines        1226     1231       +5     
  Branches      208      209       +1     
==========================================
+ Hits         1109     1114       +5     
  Misses         10       10              
  Partials      107      107
Impacted Files Coverage Δ
src/inputTime.jsx 81.81% <100%> (+5.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5cc88...3a79e5f. Read the comment docs.

Pavel Mendoza added 3 commits Aug 8, 2019
/>
);

// let input =

This comment has been minimized.

Copy link
@martijnrusschen

martijnrusschen Aug 26, 2019

Member

If this isn't needed, can you remove this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.