Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Hare to use Haiku's Layout Manager #1

Closed
soakbot opened this issue Sep 27, 2013 · 48 comments

Comments

6 participants
@soakbot
Copy link

commented Sep 27, 2013

Creator: Scott McCreary
URL: http://dev.osdrawer.net/issues/289

The main window seems to keep getting bigger every time you open it up, this needs to be fixed.
Also there's buttons that are sometimes overlapping that also need to be fixed.

CAUTION: comments not extracted from issues. See OsDrawer or the WaybackMachine for issue comments.

@scottmc scottmc changed the title The interface for Hare needs some fixing up on Haiku Convert Hare to use Haiku's Layout Manager Nov 20, 2015

@scottmc

This comment has been minimized.

Copy link
Member

commented Nov 20, 2015

This should really just be converted to use Haiku's Layout Manager instead.

@scottmc

This comment has been minimized.

Copy link
Member

commented Jan 9, 2017

This may also solve issue #6.

@scottmc scottmc added the enhancement label Jan 9, 2017

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2017

Hello! This is CodeforEvolution from GCI! Sorry I could not submit something on time as I got into a very busy situation, otherwise, when I do have time, I will continue working on this.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2017

Hey, as a status update I have been stalled with a few issues for quite some time:

  • Dragging and dropping items into the actual column list view does not work
  • When dragging items into another part of the app window an entry is created in the list, though no info is added
  • The app's functionality overall seems very broken
  • I still have to convert the app to layouting, only have removed libsanta stuff so far and still fixing from there

To see my progress so far:
https://github.com/CodeforEvolution/Hare/tree/layouting

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2017

Thanks! The only problem is the application is too unstable and unusable at the moment, and it basically has no functionality, I was wondering if you’d have any idea on fixing the above problems in the previous comment I made, as I have been stuck on those problems for a long time.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 18, 2017

Are you in GCI this year? If so there is an open task to fix an issue in Hare. Perhaps send your pending changes as a new pull request, and then after it is merged open new issues for each of the pending issues you noted up above. We can create new instances for students who want to fix more than one issue per HaikuArchive app, just ask us to open another one.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2017

Yes, I have unfortunately been quite busy though, and if anything should have time to merge in the upcoming weekend.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 18, 2017

ok, cool. I added a task for issue #2, as that's probably the biggest pending issue after fixing the layout.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 19, 2017

Turns out another student chose to work on the layout issue and has now submitted a pull request. This will likely conflict with @CodeforEvolution 's unsubmitted code.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 20, 2017

markup1
Here's a markup of my vision of what this should be like. Move genre and comment over and under year. Have three views with adjustable split bars between then, defaulted to center like shown. Fix window resizing, I recall disabling it at some point since it was causing the window to grow out of control. Make all three views have option for vertical scroll view in case contents fill up box. Fix upper left box to also use layout manager. Fix bottom status area so that it all fits in there nicer, looks cramped right now. Make text entry boxes wider, perhaps let them grow with the width of each view.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 20, 2017

@CodeforEvolution we will likely merge @friedrich12 's Pull Request once it gets updated to fix listed issues. This will likely mess up your pending work. I do like your work to Completely Redo Build System and Directory Structure, perhaps you can redo that once the layout manager coding in done. With the pending pull request it can already allow you to drag a CD onto the bottom view and populate it, so looking promising.

@HaikuArchives HaikuArchives deleted a comment from smccrearyx Dec 20, 2017

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2017

Of course, I will watch for the completed pull request, and then rebase my code once the time comes.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 21, 2017

@CodeforEvolution code has now been merged. If you want to just apply the changes you made to remove libsanta and taglib from the repo, feel free to do so. I believe there is an open task to pick any open issue for Hare and solve it. That way at least part of your work will still be useful

@ALL This issue is about half way done. The red marks on the markup image above still need to be fixed up. If you take on the task, don't be afraid to ask questions.

@friedrich12

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2017

I plan on finishing most of the UI today if not all the remaining fixes. Also can you give me some information about adding scrollbars to the window? Please also show me any coding style that must be followed if needed?

@humdingerb

This comment has been minimized.

Copy link
Member

commented Dec 22, 2017

https://www.haiku-os.org/development/ has links to information, like the Haiku Coding Guidelines and esp. the BeBook and HaikuBook that describe the API. Scrollbars are in the interface kit.
See also http://xref.plausible.coop/source/ to search through Haiku's source for examples (under apps and preferences).

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Dec 25, 2017

Hey,if all the layout changes are done, I can start reworking my code base.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 25, 2017

i think @friedrich12 was going to work on finishing up the UI changes to get it to look and work like markup. @CodeforEvolution you claimed the part 2 task, if yu intend to finished up the UI that is fine. Or you can drop that task and pick the other Hare task to "fix an open issue" on Hare and then work on the code base clean up of removing lib santa, tablib, etc. But you might want to wait to start that after the UI code is completed which might go quick if @friedrich was working on it on the 22nd. Tricky to work on a smaller project in parallel, so if you could wait a couples days that might work out.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Dec 25, 2017

Sorry about that, I will drop that task, just @ me when I can jump in.

@scottmc

This comment has been minimized.

Copy link
Member

commented Dec 30, 2017

@friedrich12 any progress on this? If so you may want to put a claim in on the task.

@scottmc

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

@CodeforEvolution feel free to jump in I guess. Be sure to use the current code.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2018

Hello! I have updated the interface quite a bit and looks now quite nice! I did find though that BScrollViews weren't actually useful with the amount of content...otherwise, should I create a pull request? You can see where I'm at here: https://www.github.com/CodeforEvolution/Hare, (use the final-layouting branch).

@scottmc

This comment has been minimized.

Copy link
Member

commented Jan 17, 2018

Keep in mind that the amount of content is likely to grow once we expand to allow for more tags. Yes, once you are happy with the code do a pull request

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2018

True, for now though, I found it to be very buggy with drawing...leaving lots of artifacts of the scroll views' contents.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2018

Well, I'll create a pull request!

@scottmc

This comment has been minimized.

Copy link
Member

commented Jan 20, 2018

You are now almost there, just need to get the bottom section working again.

@scottmc

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

New layout almost there. Is it possible to move the Apply buttoms to be in bottom right, but under the last row in the same column and not the next column over? This would allow the text entry boxes for both sections to use the full width. The drag and drop and loading of the CD seems to still be broken. But at least now the bottom view is back, just not functional yet. Overall the window is now working mostly as I envisioned it. Is it possible to make the divider bars moveable as well? I'm not converned with the ghosting issues, as most users will adjust the window to their liking and leave it that way. The default open location needs to be adjusted, right now it seems to be set to 0,0 which puts the tab off the screen. Perhaps check others apps to see where most of them set the default open position as. Nice progress.

@janus2

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

The ghosting problem is related to https://dev.haiku-os.org/ticket/3037.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

I'm now so close to finishing (Sorry for how long it's been taking, I have been busy). The only problem now is that the info from added media files aren't being added to the BColumnListView. I've used Debugger and traced through many variables, but I can't figure out why the information isn't appearing of the column list view.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Ticket #16 has to do with this issue I believe. One other note, the rows are being created, just, no information is being displayed...

1 similar comment
@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Ticket #16 has to do with this issue I believe. One other note, the rows are being created, just, no information is being displayed...

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

When I say BColumnListView is a bitch nobody listen to me ;-)
I suggest you try to add this lines in your BRefRow constructor and see the evil in the eyes:

SetField(new BBitmapField(NULL), 0);
for (int i=1; i < 10; i++)
SetField(new BStringField(B_EMPTY_STRING), i);

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

No luck unfortunatly...any other ideas?

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

I tested the code it works...

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

I don't have a cd driver I used a folder full of songs can be this the difference?

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Oh...let me double check something then...

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Well, I tried that too, what version of the Hare code are you using?

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

Master of this repo

screenshot

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Something must be wrong with my computer then...I tried the master just now and had no dice...what hrev of Haiku are you using? I'm using hrev 51818.

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

hrev 51792, but the BColumnListView is unchanged since than.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Let me try another computer...

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

Don't you have a release and a debug version? Maybe you are using an old version of the app, often this happen to me.

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

I have update my system to hrev 51818 and it works.

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

I have add a PR you can verify with that version.

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

It does work! I must've fixed the issue, and then some how broken it again...

@janus2

This comment has been minimized.

Copy link
Member

commented Feb 28, 2018

Good!

@scottmc

This comment has been minimized.

Copy link
Member

commented Feb 28, 2018

i suspect a pull request will happen soon then?

@CodeforEvolution

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2018

Yes, a pull request will come in soon. (I have been a bit busy lately)

@scottmc

This comment has been minimized.

Copy link
Member

commented Mar 5, 2018

Fixed in 05500f3

@scottmc scottmc closed this Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.