Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated the Vandelay application. #1
Merged
Conversation
src/Vandelay.cpp
Outdated
| return(0); | ||
| VandelayApp::VandelayApp() : BApplication(kSignature) { | ||
|
|
||
|
|
This comment has been minimized.
This comment has been minimized.
waddlesplash
Mar 18, 2017
Member
Extra and unnecessary spaces at beginning of function. Also please conform to Haiku coding style (https://www.haiku-os.org/development/coding-guidelines/) as much as possible re. function formatting.
This comment has been minimized.
This comment has been minimized.
AkshayAgarwal007
Mar 18, 2017
Author
Contributor
I should have updated it to conform to the coding style straight away instead of keeping it in TODO. :) I'll do that.
src/Vandelay.cpp
Outdated
| "Convert between units and all kinds of\n" | ||
| "measurements with ease.", | ||
| "Thank you" | ||
| ); |
This comment has been minimized.
This comment has been minimized.
src/VandelayWindow.cpp
Outdated
| .AddGlue() | ||
| .Add(VanView) | ||
| .AddGlue() | ||
| .End(); |
This comment has been minimized.
This comment has been minimized.
src/VandelayWindow.cpp
Outdated
| .End(); | ||
|
|
||
|
|
||
| BLayoutBuilder::Group<>(this, B_VERTICAL, B_USE_WINDOW_SPACING) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks OK aside from comments. |
AkshayAgarwal007
force-pushed the
AkshayAgarwal007:gui-work
branch
5 times, most recently
from
cedf0c5
to
b358afc
|
Looks good to me. |
|
Thanks! |
Made necessary changes to conform to Haiku coding style and updated TODO file accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AkshayAgarwal007 commentedMar 17, 2017
Previous version of the app:
After updates: